Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write tests for import and export function #200

Merged
merged 33 commits into from
Nov 12, 2018
Merged

Write tests for import and export function #200

merged 33 commits into from
Nov 12, 2018

Conversation

jitwei98
Copy link
Collaborator

No description provided.

@jitwei98
FileUtil.java: Refactor for readability
3d4c560 
FileUtilTest.java: Write test for isValidXmlFilename()
@jitwei98
Export.java: Rename saveFilteredAddressbook to saveFilteredPersons
aa0c810
@jitwei98
FileUtilTest.java: Remove unused import
d6ea7d1
@jitwei98
Pass data to export in an ObservableList instead of FilteredList in o…
d382344 
…rder to increase testability
@jitwei98
Remove unused import
4027640
@jitwei98
ExportCommandParserTest.java: Update according to the new ExportComma…
2b62539 
…ndParser
@jitwei98
ImportCommandParserTest.java: Create tests
26b2d86 
ExportCommandParserTest.java: Remove irrelevant comment
@jitwei98
ImportCommand.java: Throw CommandException if file not found
e96474d
@jitwei98
ImportCommandParserTest.java: Modify MESSAGE_INVALID_FORMAT
3406ddc
@jitwei98
CsvWriterTest.java: check if output file exists after calling write()
cf7478d
@jitwei98
ModelManagerTest.java: test importPersonsFromAddressBook() and export…
72ead57 
…FilteredAddressBook() throw NullPointerException

#addPersonsToAddressBook(): test if model is equal to the expected model after executing addPersonsToAddressBook()
@jitwei98
ImportCommandTest.java: Write tests for ImportCommand
90dd121
@jitwei98
ImportCommandTest.java: Update according to ImportCommand implementation
21bd22d
@jitwei98
ModelManager.java: Check if the person exists in the addressbook befo…
8762c75 
…re adding
@jitwei98
ImportCommand.java#execute(): check the number of persons imported th…
efe1d54 
…rough the addressbook instead of the filteredPersonList
@jitwei98
ImportCommand.java: Commit AddressBook after import
734fe4e
@jitwei98
ImportPersonsFromAddressBook(): only updateFilteredPersonList and ind…
d9032a5 
…icateAddressBookChanged when addPersonsToAddressBook adds at least one person
@jitwei98
ImportCommandTest.java: Compare commandResult only for now
0103e1e
@jitwei98
Throw IllegalValueException when user wants to export an empty addres…
e9f844e 
…sbook
@jitwei98
CsvWriterTest.java: Modify path of output file
ea07f61
@jitwei98
ExportManager.java: Fix styling
cf52555
@jitwei98
ModelManagerTest.java#exportFilteredAddressBook(): Pass in exportPath…
20c059d 
… instead of null
@jitwei98
MModelManagerTest.java#exportFilteredAddressBook(): Rename export fil…
24ef6e3 
…e path
@jitwei98
ExportManagerTest.java: Write tests
d3ccbae
@jitwei98
ModelManagerTest.java: Write tests for importPersonsFromAddressBook()
edd21a5
@jitwei98
ModelManagerTest.java: Use @before to generate xml files to be import…
768984b 
…ed during the tests
@jitwei98
ImportManagerTest.java: Write tests for ImportManager
d144b4f 
ModelManager.java#importPersonsFromAddressBook(): Use orElseThrow instead of orElse
@jitwei98
ModelManager.java: Remove trailing whitespace
4d42aa5
@jitwei98
ImportManagerTest.java: Add negative test cases
9875ea1
@jitwei98
ImportCommandTest.java: Compare person list in addressbook after import
badcf74
@jitwei98 jitwei98 added the priority.high Must do label Nov 12, 2018
@jitwei98 jitwei98 added this to the v1.4 milestone Nov 12, 2018
@jitwei98 jitwei98 self-assigned this Nov 12, 2018
@jitwei98 jitwei98 changed the title Jitwei98/tests for v1.4 Write tests for import and export function Nov 12, 2018
@jitwei98 jitwei98 mentioned this pull request Nov 12, 2018
Closed
@coveralls
Copy link

Coverage Status

Coverage increased (+2.3%) to 80.127% when pulling d1424a4 on jitwei98:jitwei98/tests-for-v1.4 into 7fcdf59 on CS2113-AY1819S1-W12-1:master.

@elstonayx elstonayx merged commit 1a6a944 into CS2113-AY1819S1-W12-1:master Nov 12, 2018
This was referenced Nov 12, 2018
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elstonayx elstonayx elstonayx approved these changes

Assignees

@jitwei98 jitwei98

Labels
priority.high Must do
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@jitwei98 @coveralls @elstonayx