Added Basic Suggest Corrections Features and Test Cases #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified AddressBookParser to accept CommandSuggestion in the default case and return the message into ParseException
Added new CommandSuggestionTest class
|
You can add something like "Resolves #74" to your PR description such that the issue related to this will be closed immediately once this PR is merged. Ref: https://help.github.com/articles/closing-issues-using-keywords/ |
jitwei98
reviewed
Oct 17, 2018
| * Suggests a command with the closest match to the inputted string. | ||
| */ | ||
| public class CommandSuggestion { | ||
| public static final String SUGGESTION_NOT_IMPLEMENTED = "Suggestion not implemented yet."; |
There was a problem hiding this comment.
Can this be declared as private instead since there's a returnSuggestion
| public class CommandSuggestion { | ||
| public static final String SUGGESTION_NOT_IMPLEMENTED = "Suggestion not implemented yet."; | ||
|
|
||
| public String returnSuggestion() { |
There was a problem hiding this comment.
Normally getters are named as getSomething()
This was referenced Nov 11, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #74