Facebook data store #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janelljchen
approved these changes
Nov 14, 2017
csuksangium
force-pushed
the
facebook-data-store
branch
from
6e36420
to
567d596
Compare
freddiev4
suggested changes
Nov 16, 2017
testapp/models.py
Outdated
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Nit-pick but can we remove this extra whitespace?
testapp/views.py
Outdated
|
|
||
| #graph = facebook.GraphAPI(access_token=myToken, version=2.10) | ||
| #profile = graph.get_object('me') | ||
| #args = {'fields' : 'address'} |
There was a problem hiding this comment.
Do we need this bit that commented out? If not can we remove it?
testapp/views.py
Outdated
| if k == 'age_range': | ||
| user_info.age_range = fb_user_info['age_range']['min'] | ||
| if k == 'religion': | ||
| user_info.religion = fb_user_info['religion'] |
There was a problem hiding this comment.
I think there might be a better approach to this, like traversing the JSON in some other way but we can come back to this for the sake of time
testapp/views.py
Outdated
|
|
||
| #def get_facebook_account(): | ||
| #user = SocialAccount.objects.get(uid="10210039294274709") | ||
| #access_token = SocialToken.objects.filter(account__user=user.user, account__provider='facebook').first() |
There was a problem hiding this comment.
Can we remove this? Or are we still saving data this way?
|
Also looks like there's some merge conflicts here; once you address the other comments I made I can go through the conflict stuff |
csuksangium
force-pushed
the
facebook-data-store
branch
from
567d596
to
e19fe93
Compare
|
did the formatting stuff and ill look into a cleaner way to parse the json |
Changes to models, views, and admin to save user info from facebook graph api Added education to User_Info field Formatting fix: unnecessary spaces
freddiev4
force-pushed
the
facebook-data-store
branch
from
e19fe93
to
1b3885e
Compare
freddiev4
approved these changes
Nov 16, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.