Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect for logout #28

Closed
wants to merge 1 commit into from
Closed

Redirect for logout #28

wants to merge 1 commit into from

Conversation

T0ny-X
Copy link
Collaborator

@T0ny-X T0ny-X commented Feb 26, 2024

Added a redirect to prevent staying in the account related pages.

@T0ny-X T0ny-X added the bug Something isn't working label Feb 26, 2024
@T0ny-X T0ny-X requested a review from hetd54 February 26, 2024 22:26
@T0ny-X T0ny-X self-assigned this Feb 26, 2024
@T0ny-X T0ny-X linked an issue Feb 26, 2024 that may be closed by this pull request
@T0ny-X T0ny-X requested a review from AD121390 February 26, 2024 22:26
Copy link

Visit the preview URL for this PR (updated for commit d0bebf4):

https://magic-kitchen-b5f37--pr28-26-log-out-doesnt-re-p8w4aq2w.web.app

(expires Mon, 04 Mar 2024 22:28:31 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d54c8b344d8aa2aca9ea249eecc40f8f204d6f90

Copy link
Collaborator

@hetd54 hetd54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment related to old code, nothing to hold you back!


const SignOut = async () => {
localStorage.clear();
redirect("/");
window.location.reload();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you are redirecting, we can remove the reload

@T0ny-X T0ny-X closed this Feb 26, 2024
@T0ny-X T0ny-X deleted the 26-log-out-doesnt-redirect branch February 26, 2024 22:30
@T0ny-X T0ny-X restored the 26-log-out-doesnt-redirect branch February 26, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log out doesn't redirect
2 participants