refactor: nicer rems.actions.components #2425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
accidentally changed when refactoring earlier
opqdonut
force-pushed
the
refactor-actions
branch
from
0e01329
to
a645495
Compare
fetching the catalogue was broken also use new comment-field also remove some unused parameters
opqdonut
force-pushed
the
refactor-actions
branch
from
a645495
to
bb2f5dc
Compare
... to avoid conflict with reagent, which uses the :key prop as the react key, which should be unique for rems.fields/multi-attachment-view, use :id instead of :key since that's the idiom for view components
opqdonut
force-pushed
the
refactor-actions
branch
from
7f966d5
to
c031dbf
Compare
1 task
Macroz
approved these changes
Nov 4, 2020
opqdonut
added a commit
that referenced
this pull request
Nov 5, 2020
Before #2425 the action comment defaulted to "", which was sent to the backend if no comment was entered. After, it defaulted to nil, which violated the API schema and resulted in a HTTP 400. Return to the old behaviour, but add TODOs for cases where it might make sense to require a nonempty comment.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #2040
Definition of Done / Review checklist
Reviewability
Documentation
Follow-up