Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSH executable throws errors while loading files #364

Closed
scottgonzalez opened this issue Mar 25, 2013 · 5 comments
Closed

WSH executable throws errors while loading files #364

scottgonzalez opened this issue Mar 25, 2013 · 5 comments

Comments

@scottgonzalez
Copy link
Contributor

While working on #359, we ran into problems with the WSH script. I don't have an environment to test in, so I asked @dmethvin to test. His problems can be found in these IRC logs

@dmethvin
Copy link
Contributor

The WSH script attempts to load the .csslintrc file but doesn't catch the error that results if the file isn't there. The wiki indicates the settings file is optional.

https://github.com/stubbornella/csslint/blob/0e85f26fa80d2da9bef8b181a6dcbe367d7afc38/src/cli/wsh.js#L123

https://github.com/stubbornella/csslint/wiki/Command-line-interface#configuration-files

Looking at the node.js equivalent it seems that returning an empty string an a missing file is the desired behavior. I can do a separate PR on that.

@stubbornella
Copy link
Member

@dmethvin - did you submit a pull request for this?

stubbornella added a commit that referenced this issue Apr 29, 2013
Fix #364. In WSH, return empty string for files not found.
@dmethvin
Copy link
Contributor

Whoops, I did not. Just did #376.

@dmethvin
Copy link
Contributor

oh darn, sorry.

@stubbornella
Copy link
Member

Thanks!

On Mon, Apr 29, 2013 at 2:26 PM, Dave Methvin notifications@github.comwrote:

oh darn, sorry.


Reply to this email directly or view it on GitHubhttps://github.com//issues/364#issuecomment-17195608
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants