Add @-ms-viewport for IE10 #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nzakas any thoughts on this? Should I just remove the offending test and refile that as a separate issue? The failure seems more related to the |
|
Yeah, adding a failing test without a fix means I can't merge it in. |
Test cases taken from the documentation in http://msdn.microsoft.com/en-us/library/ie/hh869615%28v=vs.85%29.aspx Fixes CSSLint/csslint#401 Fixes CSSLintgh-84
|
I removed the failing test, and will file it as a separate issue |
|
@nzakas is there anything that needs to be updated for this to land? |
|
Sorry, just lost track of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test cases taken from the documentation in
http://msdn.microsoft.com/en-us/library/ie/hh869615%28v=vs.85%29.aspx
Fixes CSSLint/csslint#401
This currently fails for the case of a viewport nested in a media query http://dev.w3.org/csswg/css-device-adapt/#media-queries
I'm throwing this up so maybe someone (ping @jklein) can figure out a good solution.