Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #116 #149

Merged
merged 3 commits into from
Apr 10, 2021
Merged

Fix part of #116 #149

merged 3 commits into from
Apr 10, 2021

Conversation

SanjayDevTech
Copy link
Contributor

@SanjayDevTech SanjayDevTech commented Apr 9, 2021

Explanation

I have implemented group chat community feature.
Used Realtime database to fetch chats and used Firebase-UI to display
Since this PR won't contain full fledged chat feature but it covers the basic functionality of chat.
This PR Fixes part of #116

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR does not break any part of the existing code.
  • The PR creator have carefully read & adher to the contributing guidelines of the project.
  • The PR is made to the branch that's called "develop".
  • The PR is made from a branch that is up-to-date with "develop".

@SanjayDevTech
Copy link
Contributor Author

image

This is the structure of the msg in the database.
content => Actual text content
createdTime => The timestamp at which the msg was sent
msgId => The key of the msg object
senderId => UId of the sender
senderName => Name of the sender (This can be retrieved from getDisplayName() method of FirebaseUser class.. This works only for Google or any other social login... It won't work for Email password validation)

@ddvader44 ddvader44 added gssoc21 For GSSOC 21 Level3 for experienced devs. labels Apr 9, 2021
Copy link
Member

@riturajjain2000 riturajjain2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove build.gradle achanges

Also remove the 'Community' text from the top and make the send button yellow instead of red

Rest looks good

build.gradle Outdated Show resolved Hide resolved
@SanjayDevTech
Copy link
Contributor Author

image

@riturajjain2000 riturajjain2000 merged commit 8d91497 into CSwala:develop Apr 10, 2021
@SanjayDevTech SanjayDevTech deleted the community branch April 10, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc21 For GSSOC 21 Level3 for experienced devs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants