Embed view and Bootstrap tables in the schedule template #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanor
reviewed
Aug 9, 2019
stefanor
reviewed
Aug 9, 2019
| @@ -35,7 +35,7 @@ <h1> | |||
| </div> | |||
| {% endif %} | |||
| {% for schedule_day in schedule_days %} | |||
| <table cellspacing=1 cellpadding=0> | |||
| <table cellspacing=1 cellpadding=0 class="table table-striped table-bordered"> | |||
There was a problem hiding this comment.
This is probably a better default, but I can still imagine wanting to override it, so it's tempting to do this via SCSS rather than classes.
Are cellspacing=1 cellpadding=0 still needed with these classes?
There was a problem hiding this comment.
I have removed that bit for now.
This view lacks the usual navigation features, footers and headers.
andrewshadura
force-pushed
the
embed-view
branch
from
4c6e982
to
0ac9d49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two things.
Bootstrap classes for the schedule, making it more usable even without customisations:
Embed view, suitable for embedding on another website: it has no headers, footers, navigation elements or edit controls.