Feature/redo user profile with kv #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanor
reviewed
Oct 8, 2023
drnlm
force-pushed
the
feature/redo_user_profile_with_kv
branch
from
c160e42
to
7d09aee
Compare
added 19 commits
October 13, 2023 07:40
Needed since we've dropped the github_username profile attribute.
drnlm
force-pushed
the
feature/redo_user_profile_with_kv
branch
from
7d09aee
to
8ff12cc
Compare
stefanor
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a possible approach to getting rid of the hard coded twitter / github bits in the profile and making them more configurable.
We replace them with configured lists of sites (there's an argument we should have just one list), and use the key-value infrastructure to actually store the data.
I still need to look at validation and translation support.
This should resolve #661 and #148