Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CBRD-24167] Remove the unused LOG_TOPOPS_TYPE type. #3324

Merged
merged 1 commit into from
Jan 20, 2022
Merged

[CBRD-24167] Remove the unused LOG_TOPOPS_TYPE type. #3324

merged 1 commit into from
Jan 20, 2022

Conversation

jinbekim
Copy link
Contributor

http://jira.cubrid.org/browse/CBRD-24167

Purpose

  • Refactoring, Remove log_topops_type in log_impl.h

Implementation

  • Remove enum log_topops_type and related typedef in log_impl.h

Remarks

  • N/A

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2022

Codecov Report

Merging #3324 (06d3771) into develop (7a764fd) will decrease coverage by 3.49%.
The diff coverage is n/a.

❗ Current head 06d3771 differs from pull request most recent head 975521f. Consider uploading reports for the commit 975521f to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3324      +/-   ##
===========================================
- Coverage    51.91%   48.42%   -3.50%     
===========================================
  Files          500      500              
  Lines       397893   396932     -961     
===========================================
- Hits        206570   192199   -14371     
- Misses      191323   204733   +13410     
Impacted Files Coverage Δ
src/transaction/log_impl.h 80.00% <ø> (ø)
src/loaddb/load_common.hpp 0.00% <0.00%> (-100.00%) ⬇️
src/loaddb/load_sa_loader.hpp 0.00% <0.00%> (-100.00%) ⬇️
src/query/scan_json_table.cpp 0.00% <0.00%> (-83.11%) ⬇️
src/loaddb/load_driver.cpp 0.00% <0.00%> (-81.82%) ⬇️
src/compat/db_json_path.cpp 0.00% <0.00%> (-78.07%) ⬇️
src/loaddb/load_semantic_helper.cpp 0.00% <0.00%> (-77.69%) ⬇️
src/xasl/access_json_table.cpp 0.00% <0.00%> (-73.03%) ⬇️
src/loaddb/load_object_table.c 0.00% <0.00%> (-72.28%) ⬇️
src/loaddb/load_scanner.hpp 0.00% <0.00%> (-70.00%) ⬇️
... and 175 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a764fd...975521f. Read the comment docs.

Copy link
Contributor

@wrlawodms wrlawodms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your first contribution!

@hornetmj hornetmj merged commit f91a94a into CUBRID:develop Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants