Pulled EmailProviderConfig credentials from last enabled for site rather than SiteConfiguration. #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her than SiteConfiguration. Here were two decisions in moving this Third-party Auth credential information from SiteConfiguration: - Third-Party Auth Provider backend should contain all relevant information is it's the one who uses the information. - Allows for multiple backend from BigCommerceCustomer provider to have it stored on the ProviderConfiguration rather than SiteConfiguration (e.g. default site, another subsite).
ztraboo
force-pushed
the
feature.juniper/ztraboo/jyIZBpRtp0C2umLkLXbGjWQAGapM/Customer-Authentication-BigCommerce
branch
from
751ee92
to
3efa294
Compare
11 tasks
ztraboo
added
cu-release/juniper.master
bigcommerce
and removed
cu-release/juniper.master
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here were two decisions in moving this Third-party Auth credential information from SiteConfiguration: