Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moves segments import to normal location. #100

Merged
merged 1 commit into from
Nov 21, 2019
Merged

Moves segments import to normal location. #100

merged 1 commit into from
Nov 21, 2019

Conversation

kylebgorman
Copy link
Collaborator

See for context:
cldf/segments#49 (comment)

@kylebgorman kylebgorman mentioned this pull request Nov 21, 2019
Closed
jacksonllee
jacksonllee approved these changes Nov 21, 2019
View reviewed changes
Copy link
Collaborator

@jacksonllee jacksonllee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Glad to see that the segments folks are proactive in support and maintenance!

@kylebgorman kylebgorman merged commit ac38d5b into master Nov 21, 2019
@kylebgorman kylebgorman deleted the segments branch November 25, 2019 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacksonllee jacksonllee jacksonllee approved these changes

@lfashby lfashby Awaiting requested review from lfashby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylebgorman @jacksonllee