Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUE-241: Use mypy for type checking #247

Merged
merged 12 commits into from
Oct 25, 2020
Merged

ISSUE-241: Use mypy for type checking #247

merged 12 commits into from
Oct 25, 2020

Commits on Oct 19, 2020

  1. ISSUE-241: Ignoring 'env' and '.idea' directories

    @ben-fernandes
    ben-fernandes committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    e0a1a79 View commit details
    Browse the repository at this point in the history

  2. ISSUE-241: Added 'mypy' to 'requirements.txt'

    @ben-fernandes
    ben-fernandes committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    5c6a504 View commit details
    Browse the repository at this point in the history

  3. ISSUE-241: Added 'Type checking' step to CircleCI

    @ben-fernandes
    ben-fernandes committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    3fb46ed View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2020

  1. ISSUE-241: Fixed mypy issues

    @ben-fernandes
    ben-fernandes committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    eb946c3 View commit details
    Browse the repository at this point in the history

  2. ISSUE-241: Updated documentation

    @ben-fernandes
    ben-fernandes committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    20e5127 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into ISSUE-241

    @ben-fernandes
    ben-fernandes committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    1adf49f View commit details
    Browse the repository at this point in the history

  4. ISSUE-241: Added mypy to the correct 'requirements.txt'

    @ben-fernandes
    ben-fernandes committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    d5bd8f9 View commit details
    Browse the repository at this point in the history

  5. ISSUE-241: Ran Black formatter 

    Also updated the contribution guidelines to include this as a step
    @ben-fernandes
    ben-fernandes committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    8ae7400 View commit details
    Browse the repository at this point in the history

  6. ISSUE-241: Markups 

    ISSUE-241: Markup - Alphabetised 'requirements.txt'
ISSUE-241: Markup - Log invalid page title
ISSUE-241: Markup - Alphabetised 'test_scrape.py' imports
ISSUE-241: Markup - Added explanatory comment
ISSUE-241: Markup - Improved 'config_dict' typing
ISSUE-241: Markup - Improved 'scrape.py' typing
    @ben-fernandes
    ben-fernandes committed Oct 23, 2020
    1 Configuration menu
    Copy the full SHA
    4fd09d2 View commit details
    Browse the repository at this point in the history

  7. ISSUE-241: Markup - Using logger interpolation

    @ben-fernandes
    ben-fernandes committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    adf125e View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2020

  1. ISSUE-241: Markups

    @ben-fernandes
    ben-fernandes committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    1d3089a View commit details
    Browse the repository at this point in the history

  2. ISSUE-241: Markup - Added working dir to Circle CI config

    @ben-fernandes
    ben-fernandes committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    afb795c View commit details
    Browse the repository at this point in the history