Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sprint16 kl projection #167

Merged
merged 11 commits into from
Jan 25, 2023
Merged

Sprint16 kl projection #167

merged 11 commits into from
Jan 25, 2023

Conversation

amal-ghamdi
Copy link
Contributor

@amal-ghamdi amal-ghamdi commented Dec 23, 2022 •
edited
Loading

Closes #168

@amal-ghamdi
Copy link
Contributor Author

Hi @jakobsj and @nabriis. I finished this KL projection pull request, but there is a general design/convention question: should we allow fun2par to be a projection or should it always be either exact or not supported. This functionality is very helpful for example in the heat1D problem where we want to look at the projected signal in the coefficient space (to get plot_ci for parameters for example). We can discuss in the stand-up.

nabriis
nabriis approved these changes Jan 13, 2023
View reviewed changes
Copy link
Collaborator

@nabriis nabriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking at it I think its OK to have this feature added. With the warning message there is no doubt that its not the full inverse.

cuqi/_cuqi_global_vars.py Outdated Show resolved Hide resolved
cuqi/geometry/_geometry.py Outdated Show resolved Hide resolved
amal-ghamdi and others added 4 commits January 13, 2023 11:47
jakobsj
jakobsj requested changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@jakobsj jakobsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @amal-ghamdi it looks good - I've requested some minor additions to the comments and tests.

tests/test_geometry.py Show resolved Hide resolved
cuqi/geometry/_geometry.py Outdated Show resolved Hide resolved
cuqi/geometry/_geometry.py Outdated Show resolved Hide resolved
@amal-ghamdi
Copy link
Contributor Author

Thank you @jakobsj for your very helpful feedback! I addressed your comments, please let me know if you have further suggestions for improvements

jakobsj
jakobsj approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@jakobsj jakobsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the extra doc, looks good!

@amal-ghamdi amal-ghamdi merged commit 16e3924 into main Jan 25, 2023
@amal-ghamdi amal-ghamdi deleted the sprint16_KL_projection branch January 25, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabriis nabriis nabriis approved these changes

@jakobsj jakobsj jakobsj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add projection (fun2par) for KLExpansion
3 participants
@amal-ghamdi @jakobsj @nabriis