Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprint16 fix doc test ci #172

Merged
merged 3 commits into from
Jan 10, 2023
Merged

Sprint16 fix doc test ci #172

merged 3 commits into from
Jan 10, 2023

Conversation

amal-ghamdi
Copy link
Contributor

closes #171

@amal-ghamdi
Copy link
Contributor Author

Hi @nabriis, we have some CI issues related to np.float being deprecated in numpy and 'logo' being deprecated in sphinx 6.0.0. I removed the use of np.float and made a hack to overcome the sphinx issue until pydata-theme make the appropriate update. Issue #171 has more details about this. It will be great if you can take a look at this PR

Copy link
Collaborator

@nabriis nabriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amal-ghamdi
Copy link
Contributor Author

Hi @jakobsj, it will be great if you can take a look at this PR. It is a quick fix for pytest and documentation CI due to external updates. More details in #171.

Copy link
Contributor

@jakobsj jakobsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@amal-ghamdi amal-ghamdi merged commit 8044d6e into main Jan 10, 2023
@amal-ghamdi amal-ghamdi deleted the sprint16_fix_doc_test_CI branch January 10, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix documentation and pytest workflow
3 participants