Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Data and CUQIarray classes to a separate module (array module) #188

Merged
merged 6 commits into from
Feb 22, 2023

Conversation

amal-ghamdi
Copy link
Contributor

@amal-ghamdi amal-ghamdi commented Feb 16, 2023

closes #161

@amal-ghamdi amal-ghamdi marked this pull request as ready for review February 22, 2023 03:39
Copy link
Contributor

@jakobsj jakobsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amal-ghamdi, seems a straightforward replacement so should be fine. Do we know that all instances of cuqi.samples.CUQIarray across all modules, tests, demos etc. have been replaced?

Copy link
Collaborator

@nabriis nabriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nabriis nabriis merged commit e122312 into main Feb 22, 2023
@nabriis nabriis deleted the sprint17_array_module branch February 22, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider creating a module for CUQIarray. cuqi.samples.CUQIarray seems somewhat unnatural
3 participants