Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use scipy minimize solver for most problems solving for MAP #201

Merged
merged 1 commit into from
Apr 23, 2023
Merged

Use scipy minimize solver for most problems solving for MAP #201

merged 1 commit into from
Apr 23, 2023

Conversation

nabriis
Copy link
Collaborator

@nabriis nabriis commented Mar 26, 2023 •
edited
Loading

This uses the scipy minimize solver for most MAP problems, but specifically L-BFGS-B for the Cauchy diff type. This is how we do it in the paper.

Closes #215

amal-ghamdi
amal-ghamdi approved these changes Apr 22, 2023
View reviewed changes
Copy link
Contributor

@amal-ghamdi amal-ghamdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I added a suggestion of an issue for future consideration

cuqi/problem/_problem.py Show resolved Hide resolved
@nabriis nabriis mentioned this pull request Apr 23, 2023
Open
@nabriis nabriis merged commit 56d83bd into main Apr 23, 2023
@nabriis nabriis deleted the sprint18_MAP_solvers branch April 23, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakobsj jakobsj jakobsj approved these changes

@amal-ghamdi amal-ghamdi amal-ghamdi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specialize MAP solving
3 participants
@nabriis @amal-ghamdi @jakobsj