Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cookie phantom and update Deconvolution2D to use cuqi.data #275

Merged
merged 4 commits into from
Sep 28, 2023
Merged

Add cookie phantom and update Deconvolution2D to use cuqi.data #275

merged 4 commits into from
Sep 28, 2023

Conversation

nabriis
Copy link
Collaborator

@nabriis nabriis commented Sep 21, 2023

Closes #242

amal-ghamdi
amal-ghamdi reviewed Sep 21, 2023
View reviewed changes
Copy link
Contributor

@amal-ghamdi amal-ghamdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nabriis for this addition! It looks great, I only have few comments for your consideration.

One additional point, if there are already tests for the 2D phantoms, maybe the test could be expanded to include the cookie phantom (by adding new test parameter).

cuqi/testproblem/_testproblem.py Show resolved Hide resolved
@nabriis nabriis mentioned this pull request Sep 27, 2023
Open
jakobsj
jakobsj requested changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@jakobsj jakobsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nabriis Thanks for adding the nice cookie phantom! OVerall the PR looks good and straightforward and I just added a few minor comments.

cuqi/data/_data.py Show resolved Hide resolved
cuqi/data/_data.py Show resolved Hide resolved
cuqi/data/_data.py Show resolved Hide resolved
amal-ghamdi
amal-ghamdi approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@amal-ghamdi amal-ghamdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jakobsj
jakobsj approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@jakobsj jakobsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for adding the additional documentation, in particular explaining the choices of weights for conversion from rgb to gray, I didn't know about that!

@nabriis nabriis merged commit d009500 into main Sep 28, 2023
5 checks passed
@nabriis nabriis deleted the 242_add_phantom_cookie branch September 28, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakobsj jakobsj jakobsj approved these changes

@amal-ghamdi amal-ghamdi amal-ghamdi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add phantom="cookie"
3 participants
@nabriis @amal-ghamdi @jakobsj