Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update demos/demo35_FD_gradient.py to test NUTS and ULA with FD approximated gradients #307

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

chaozg
Copy link
Contributor

@chaozg chaozg commented Nov 8, 2023

This closes #157 for now but feel free to reopen if any bug re-appears in the future.

Copy link
Collaborator

@nabriis nabriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@amal-ghamdi amal-ghamdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaozg chaozg merged commit dab78f8 into main Nov 9, 2023
6 checks passed
@chaozg chaozg deleted the sprint22_check_NUTS_with_FD_gradient branch November 9, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix bug: NUTS does not work with posteriors when FD approximation gradient is used (use_FD=True)
3 participants