-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tune to pCN and rename pCN to PCN #418
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chaozg. Glad to see the change was relatively straight forward. I had a few comments.
Thanks @nabriis , I've updated the codes according to your comment : ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chaozg. I could not see the state keys was updated. I also wanted to see if you could try adding this sampler to the checkpointing unit tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Sorry for the slow review ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple of small points.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for consulting with @furibec and adding the reference and additional explanation, as well as the new issue to revert the value. Happy for this to be merged now!
fixed #415
fixed #403
What's the issue:
pCNNew
,tune
method was empty and the unit test onwarmup
was omitted;pCNNew
should bePCNNew
to keep consistency with other samplers, likeULA
andLinearRTO
What I did:
tune
which is basically copy-paste from the old sampler;self.lambd
in constructor;PCNNew
'swarmup
intests/zexperimental/test_mcmc.py
;PCNNew
from exception for unit test on history state intests/zexperimental/test_mcmc.py
;Gaussian
as it is now being checked invalidate_target
;pCNNew
toPCNNew
while keeping the oldpCN
untouched.