Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure constants are stored in densities when reducing to single density in joint distribution #482

Merged
merged 4 commits into from
Aug 31, 2024
Merged

Ensure constants are stored in densities when reducing to single density in joint distribution #482

merged 4 commits into from
Aug 31, 2024

Conversation

nabriis
Copy link
Collaborator

@nabriis nabriis commented Aug 20, 2024

Closes #481

@nabriis nabriis changed the title Ensure constants are stored in posterior when returning from joint dist Ensure constants are stored in densities when reducing to single density in joint distribution Aug 22, 2024
chaozg
chaozg reviewed Aug 26, 2024
View reviewed changes
Copy link
Contributor

@chaozg chaozg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nabriis for this nice PR, particularly the accompanying test cases. I only leave some tiny comments.

tests/test_joint_distribution.py Outdated Show resolved Hide resolved
tests/test_joint_distribution.py Show resolved Hide resolved
@nabriis @chaozg
Fix typo in text for unit test
01045f4 
Co-authored-by: chaozg <69794131+chaozg@users.noreply.github.com>
@nabriis nabriis requested a review from chaozg August 26, 2024 09:08
chaozg
chaozg approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@chaozg chaozg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

amal-ghamdi
amal-ghamdi reviewed Aug 27, 2024
View reviewed changes
Copy link
Contributor

@amal-ghamdi amal-ghamdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nabriis, this looks great and very nice testing! I added a few questions.

cuqi/distribution/_joint_distribution.py Outdated Show resolved Hide resolved
cuqi/distribution/_joint_distribution.py Show resolved Hide resolved
@nabriis
Copy link
Collaborator Author

nabriis commented Aug 27, 2024

Thanks for the review @amal-ghamdi. I answered your questions. Let me know if there are any further or if my answer does not make sense :)

amal-ghamdi
amal-ghamdi reviewed Aug 28, 2024
View reviewed changes
Copy link
Contributor

@amal-ghamdi amal-ghamdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nabriis for the clarification :). In one of the questions I have a follow-up comment.

amal-ghamdi
amal-ghamdi approved these changes Aug 31, 2024
View reviewed changes
Copy link
Contributor

@amal-ghamdi amal-ghamdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nabriis for addressing this. LGTM!

@nabriis nabriis merged commit b382811 into main Aug 31, 2024
6 checks passed
@nabriis nabriis deleted the fix_481_joint_distribution branch August 31, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amal-ghamdi amal-ghamdi amal-ghamdi approved these changes

@chaozg chaozg chaozg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Joint distribution conditioning on out-of-bounds values
3 participants
@nabriis @amal-ghamdi @chaozg