-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pandapower interface #287
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #287 +/- ##
===========================================
- Coverage 78.81% 77.83% -0.98%
===========================================
Files 153 157 +4
Lines 13011 13241 +230
===========================================
+ Hits 10254 10306 +52
- Misses 2757 2935 +178
Continue to review full report at Codecov.
|
Hantao, Let us keep it here. I'll work on it after I finalize the issues we discussed today, expecting by the end of this week. Regards, |
Hantao, I have finalized most of the pandapower interface functions, where the remaining features (enhance the conversion by file I/O, add support of piece-wise cost functions) can be done in the future. The example I write in ex11 can be used to build the self-test as a baseline. Regards, |
The checks failed but I have no idea how to solve them. It seems that the default environment does not include pandapower. |
I will work on it next week by adding "optional" packages for ANDES. It will allow installing |
Copied the pandapower interface description to below. We might need to add a bit to it and move it to "Getting Started" - "Interoperability" (a new section.
|
I would like to rename some functions in the pandapower interface. It's difficult to guess what |
I moved |
case300.m issueHantao, Regarding case300, the conclusions are: 1) ANDES and the interface work well, 2) the differences of PF between ANDES and pandapower are acceptable. The detailed info is listed below:
PF results comparison:
Although the PF results are inconsistent, the max gap of voltage amplitude between |
Hi @jinningwang , is there further changes to this PR? |
Got it. Thanks! |
All my thoughts have been covered. |
Great. We will need a test for the pandapower interface. I might let you do it this time. You will find import numpy as np
...
to_pandapower(..., verify=False)
# manually extract the voltage and voltage angle vectors, and do
np.testing.assert_almost_equal(v_andes, v_pd)
np.testing.assert_almost_equal(a_andes, v_pd) to compare the power flow results from ANDES and pandapower. One test can be written for |
I would love to do it, a great chance to learn how to write a test. |
Hantao, I added two tests for pandapower interface. Regards, |
Yes, six decimal digits should be okay.
From: Jinning Wang ***@***.***>
Sent: Friday, March 25, 2022 12:09 PM
To: cuihantao/andes ***@***.***>
Cc: Hantao Cui ***@***.***>; Comment ***@***.***>
Subject: Re: [cuihantao/andes] Add pandapower interface (PR #287)
Hantao,
I added two tests for pandapower interface.
The power flow test cannot pass under default settings. Then I decreased the decimal of np.testing.assert_almost_equal to 6. Is this acceptable?
Regards,
Jinning
—
Reply to this email directly, view it on GitHub <https://github.com/cuihantao/andes/pull/287#issuecomment-1079228819> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABSNZA4DNJUGLJ4GVKUFJK3VBXXJXANCNFSM5QGY3X7A> .
You are receiving this because you commented. <https://github.com/notifications/beacon/ABSNZA4ZQ5E3CSQUT3CIV7LVBXXJXA5CNFSM5QGY3X7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOIBJ3TEY.gif> Message ID: ***@***.*** ***@***.***> >
|
Kudos, SonarCloud Quality Gate passed! |
@jinningwang Jinning, I found a better place for the notebook for pandapower interface. In my latest In the "Examples" tab, I added a new section for "Interoperability" in the sidebar. It should make navigation more easily. Let me know if you have any thoughts. |
to_pandapower
,ssa_link
,opp_res
,ssp_cost
.ex11.ipynb
.The power flow validation of the conversion is included in the
to_pandapower
.