-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in pandapower interface #302
Conversation
I have tested the interface with pjm, kundur, ieee14, ieee39, and wecc. |
Codecov Report
@@ Coverage Diff @@
## develop #302 +/- ##
===========================================
+ Coverage 78.01% 78.09% +0.07%
===========================================
Files 158 158
Lines 13462 13508 +46
===========================================
+ Hits 10503 10549 +46
Misses 2959 2959
Continue to review full report at Codecov.
|
Hantao, The interface is improved with all those bug fixes and refactoring. Regards, |
Hantao, The ACOPF of the converted 39-bus case from ANDES runs into divergence error, as we discussed yesterday. The error is detected to be caused by large line limits. In the converted case, the limit is 99999.0, which is also the default value in the interface. I decreased the default value to 100. Similar to the generator controllable option, I plan to add an option for user-defined line limits. It should be a quick job, and I plan to do it by the end of this week. Let us keep this PR open till I finish that. Regards, |
Kudos, SonarCloud Quality Gate passed! |
Fix bug in pandapower interface:
to_pandapower
to_pandapower
with multiple sub-functionsto_pandapower
with multiple conditions: a) no dynamic devices, b) oneStaticGen
to manySynGen
orDG
make_link_table
: refactormake_link_table
with new sub-functionstest_pandapower
: refactor test with multiple casesrunopp_map
: includeDG
in the results