Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce code duplication in argparse config #50

Closed

Conversation

luis261
Copy link
Contributor

@luis261 luis261 commented Apr 12, 2024

There might still be more to improve here, but this seems like an improvement over the existing code, certainly less verbose and a bit more readable.

@luis261 luis261 marked this pull request as ready for review April 12, 2024 22:43
@CYB3RMX
Copy link
Owner

CYB3RMX commented Apr 15, 2024

Could you please don't create requests before pulling your new changes? Because it causes conflict errors.

@CYB3RMX CYB3RMX closed this Apr 15, 2024
@luis261
Copy link
Contributor Author

luis261 commented Apr 15, 2024

Yeah, that's my bad. I was aware of that when creating the initial set of PRs, but there was no way to avoid conflicts and still "demo" the different areas of improvement for the main module. I'll be sure to prevent conflicts in the future (I'll simply tackle the remaining topics sequentially).

Instead of pulling master to the branches on my forks for conflict resolution I'll just throw them away and create new branches.
This way we'll get a more concise history without the additional conflict resolution merges. I'll submit the new PRs (with the existing changes) this evening.

@luis261 luis261 deleted the compressed-parser-config-section branch April 15, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants