Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add label to authenticator model #32

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Add label to authenticator model #32

merged 1 commit into from
Jan 28, 2020

Conversation

tpazderka
Copy link
Contributor

Close #31

@tpazderka tpazderka requested a review from ziima January 20, 2020 17:16
@codecov-io
Copy link

codecov-io commented Jan 20, 2020 •
edited
Loading

Codecov Report

Merging #32 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   98.97%   98.98%   +0.01%     
==========================================
  Files          27       28       +1     
  Lines         777      789      +12     
  Branches       30       30              
==========================================
+ Hits          769      781      +12     
  Misses          4        4              
  Partials        4        4
Impacted Files Coverage Δ
django_fido/migrations/0012_authenticator_label.py 100% <100%> (ø)
django_fido/forms.py 100% <100%> (ø) ⬆️
django_fido/models.py 100% <100%> (ø) ⬆️
django_fido/views.py 98.75% <100%> (ø) ⬆️
django_fido/tests/test_forms.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7a18de...ec15686. Read the comment docs.

@tpazderka tpazderka changed the title Add migrations Add label to authenticator model Jan 21, 2020
ziima
ziima requested changes Jan 22, 2020
View reviewed changes
Copy link
Member

@ziima ziima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Label doesn't seem to be reflected in registration process.

django_fido/migrations/0012_authenticator_label.py Outdated
@@ -0,0 +1,18 @@
# Generated by Django 2.2.9 on 2020-01-20 17:01
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migrations should be generated by the lowest supported Django version.

@tpazderka
Copy link
Contributor Author

Updated

@tpazderka tpazderka mentioned this pull request Jan 28, 2020
Closed
@ziima ziima merged commit ec15686 into master Jan 28, 2020
@ziima ziima deleted the add-label branch January 28, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziima ziima ziima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add label to Authenticator model
3 participants
@tpazderka @codecov-io @ziima