Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor client #626

Merged
merged 4 commits into from
Mar 19, 2019
Merged

Refactor client #626

merged 4 commits into from
Mar 19, 2019

Conversation

tpazderka
Copy link
Collaborator

  • Any changes relevant to users are recorded in the CHANGELOG.md.
  • The documentation has been updated, if necessary.

Touch of refactoring...

Removed duplicated methods on Clients.

@codecov-io
Copy link

codecov-io commented Mar 12, 2019

Codecov Report

Merging #626 into master will increase coverage by 0.28%.
The diff coverage is 70.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #626      +/-   ##
==========================================
+ Coverage   61.51%   61.79%   +0.28%     
==========================================
  Files          62       62              
  Lines       11140    11094      -46     
  Branches     1973     1956      -17     
==========================================
+ Hits         6853     6856       +3     
+ Misses       3727     3681      -46     
+ Partials      560      557       -3
Impacted Files Coverage Δ
src/oic/oic/__init__.py 66.13% <100%> (+0.7%) ⬆️
src/oic/oauth2/__init__.py 69.33% <50%> (+3.83%) ⬆️
src/oic/utils/http_util.py 68.67% <0%> (+0.57%) ⬆️
src/oic/utils/authn/user.py 64.22% <0%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b3dfcb...e480f7c. Read the comment docs.

@CZ-NIC CZ-NIC deleted a comment Mar 12, 2019
@CZ-NIC CZ-NIC deleted a comment Mar 12, 2019
@tpazderka
Copy link
Collaborator Author

Part of #629

Copy link
Collaborator

@schlenk schlenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tpazderka tpazderka merged commit 21ed5af into master Mar 19, 2019
@tpazderka tpazderka deleted the refactor_client branch March 19, 2019 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants