Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Server classes. #627

Merged
merged 1 commit into from
Mar 19, 2019
Merged

Refactor Server classes. #627

merged 1 commit into from
Mar 19, 2019

Conversation

tpazderka
Copy link
Collaborator

@tpazderka tpazderka commented Mar 12, 2019

  • Any changes relevant to users are recorded in the CHANGELOG.md.
  • The documentation has been updated, if necessary.

A touch of refactoring. Pruned Server classes.

@codecov-io
Copy link

codecov-io commented Mar 12, 2019

Codecov Report

Merging #627 into master will decrease coverage by 0.02%.
The diff coverage is 70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #627      +/-   ##
==========================================
- Coverage   61.51%   61.49%   -0.03%     
==========================================
  Files          62       62              
  Lines       11140    11140              
  Branches     1973     1974       +1     
==========================================
- Hits         6853     6850       -3     
- Misses       3727     3729       +2     
- Partials      560      561       +1
Impacted Files Coverage Δ
src/oic/oauth2/__init__.py 65.38% <100%> (-0.13%) ⬇️
src/oic/oic/__init__.py 65.2% <66.66%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b3dfcb...bec3ad2. Read the comment docs.

@tpazderka
Copy link
Collaborator Author

Part of #629

Copy link
Collaborator

@schlenk schlenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok. Only some comment spelling fixes needed.

body=None):
return oauth2.Server.parse_token_request(self, request, body)
def parse_token_request(self, request=AccessTokenRequest, body=None):
"""Overriden to use OIC Message type."""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overridden

body=None):
return oauth2.Server.parse_refresh_token_request(self, request, body)
keyjar=None, verify=True, sender='', **kwargs):
"""Overriden to use OIC Message type."""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overridden

"""Overriden to use OIC Message type."""
if 'keys' in kwargs:
keyjar = kwargs['keys']
warnings.warn('`keys` are renamed to `keyjar`, please update your code.', DeprecationWarning)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keys was renamed ...

return super().parse_jwt_request(request=request, txt=txt, keyjar=keyjar, verify=verify, sender=sender)

def parse_refresh_token_request(self, request=RefreshAccessTokenRequest, body=None):
"""Overriden to use OIC Message type."""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overridden

@tpazderka
Copy link
Collaborator Author

The typos were fixed.

@tpazderka tpazderka merged commit 64e5944 into master Mar 19, 2019
@tpazderka tpazderka deleted the refactor_server branch March 19, 2019 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants