-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Server classes. #627
Conversation
Codecov Report
@@ Coverage Diff @@
## master #627 +/- ##
==========================================
- Coverage 61.51% 61.49% -0.03%
==========================================
Files 62 62
Lines 11140 11140
Branches 1973 1974 +1
==========================================
- Hits 6853 6850 -3
- Misses 3727 3729 +2
- Partials 560 561 +1
Continue to review full report at Codecov.
|
Part of #629 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks ok. Only some comment spelling fixes needed.
src/oic/oic/__init__.py
Outdated
body=None): | ||
return oauth2.Server.parse_token_request(self, request, body) | ||
def parse_token_request(self, request=AccessTokenRequest, body=None): | ||
"""Overriden to use OIC Message type.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overridden
src/oic/oic/__init__.py
Outdated
body=None): | ||
return oauth2.Server.parse_refresh_token_request(self, request, body) | ||
keyjar=None, verify=True, sender='', **kwargs): | ||
"""Overriden to use OIC Message type.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overridden
src/oic/oic/__init__.py
Outdated
"""Overriden to use OIC Message type.""" | ||
if 'keys' in kwargs: | ||
keyjar = kwargs['keys'] | ||
warnings.warn('`keys` are renamed to `keyjar`, please update your code.', DeprecationWarning) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keys
was renamed ...
src/oic/oic/__init__.py
Outdated
return super().parse_jwt_request(request=request, txt=txt, keyjar=keyjar, verify=verify, sender=sender) | ||
|
||
def parse_refresh_token_request(self, request=RefreshAccessTokenRequest, body=None): | ||
"""Overriden to use OIC Message type.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overridden
19b6557
to
bec3ad2
Compare
The typos were fixed. |
CHANGELOG.md
.A touch of refactoring. Pruned Server classes.