Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included id_token_jwt in token response #805

Closed

Conversation

infohash
Copy link
Contributor

The ID token JWT needs to be passed in the access token response to be usable as id_token_hint for RP-Initiated Logout. Refer to RP-Initiated Logout specification.

The existing code replaces JWT with the verified IdToken instance but it should be preserved. I've added id_token_jwt which stores signed and serialised ID token.

Copy link
Collaborator

@tpazderka tpazderka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The quality check is failing.

@infohash infohash closed this May 2, 2022
@infohash infohash reopened this May 2, 2022
@infohash
Copy link
Contributor Author

infohash commented May 2, 2022

@tpazderka Merged from upstream. Now all test cases are passing. Can you fix the failing job of build (3.6):

ERROR:   py36: commands failed
SKIPPED:  py37: InterpreterNotFound: python3.7
  py38: commands succeeded
  docs: commands succeeded
  quality: commands succeeded
Error: Process completed with exit code 1.

@tpazderka
Copy link
Collaborator

Yeah, I have decided to drop 3.6 so that should fix the issue :)

@infohash infohash closed this May 3, 2022
@infohash infohash reopened this May 3, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #805 (96893da) into master (a59f34c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #805      +/-   ##
==========================================
+ Coverage   63.70%   63.72%   +0.01%     
==========================================
  Files          64       64              
  Lines       11846    11850       +4     
  Branches     2401     2410       +9     
==========================================
+ Hits         7547     7551       +4     
- Misses       3701     3702       +1     
+ Partials      598      597       -1     
Impacted Files Coverage Δ
src/oic/oic/message.py 69.90% <100.00%> (+0.05%) ⬆️
src/oic/utils/authn/user.py 63.41% <0.00%> (-0.82%) ⬇️
src/oic/utils/http_util.py 69.25% <0.00%> (-0.58%) ⬇️
src/oic/utils/client_management.py 50.37% <0.00%> (-0.38%) ⬇️
src/oic/extension/sts.py 0.00% <0.00%> (ø)
src/oic/utils/keyio.py 71.56% <0.00%> (+0.13%) ⬆️
src/oic/oauth2/message.py 74.14% <0.00%> (+0.42%) ⬆️
src/oic/utils/time_util.py 91.71% <0.00%> (+1.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a59f34c...96893da. Read the comment docs.

@tpazderka tpazderka closed this in 3d97d5a May 4, 2022
@infohash infohash deleted the feature/id-token-jwt-in-token-response branch May 22, 2022 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants