-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Included id_token_jwt in token response #805
Included id_token_jwt in token response #805
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The quality check is failing.
@tpazderka Merged from upstream. Now all test cases are passing. Can you fix the failing job of build (3.6):
|
Yeah, I have decided to drop 3.6 so that should fix the issue :) |
…id-token-jwt-in-token-response
Codecov Report
@@ Coverage Diff @@
## master #805 +/- ##
==========================================
+ Coverage 63.70% 63.72% +0.01%
==========================================
Files 64 64
Lines 11846 11850 +4
Branches 2401 2410 +9
==========================================
+ Hits 7547 7551 +4
- Misses 3701 3702 +1
+ Partials 598 597 -1
Continue to review full report at Codecov.
|
The ID token JWT needs to be passed in the access token response to be usable as id_token_hint for RP-Initiated Logout. Refer to RP-Initiated Logout specification.
The existing code replaces JWT with the verified IdToken instance but it should be preserved. I've added
id_token_jwt
which stores signed and serialised ID token.