Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiles/graphic_drivers: Add open nvidia modules profiles #127

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

ventureoo
Copy link
Member

No description provided.

@ptr1337
Copy link
Member

ptr1337 commented Aug 9, 2024

Tomorrow should come the 560 Driver into the CachyOS repo, as soon 6.10.4 drops.
Can you undraft it?

@ventureoo ventureoo marked this pull request as ready for review August 9, 2024 15:55
@ventureoo
Copy link
Member Author

Tomorrow should come the 560 Driver into the CachyOS repo, as soon 6.10.4 drops. Can you undraft it?

Sure.

@vnepogodin
Copy link
Member

priority looks incorrect here.
higher priority value -> getting sorted as first in the Vec. therefore will get installed the profile which is the first to be found for the device in normal order from begin..end

@ventureoo
Copy link
Member Author

priority looks incorrect here. higher priority value -> getting sorted as first in the Vec. therefore will get installed the profile which is the first to be found for the device in normal order from begin..end

This issue is that the newest profile tends to have very generic matching conditions, like device_ids = '*", so if we start there, that profile will most likely be selected first and all others will not be installed, even if we are dealing with a card that needs the 390xx driver. So we must first check all the "old" profiles and discard them via device_name_pattern, so that at the end we have the most suitable one selected.

Copy link
Member

@vnepogodin vnepogodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine

@vnepogodin vnepogodin merged commit 0d3ef56 into CachyOS:master Aug 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants