Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When display a tree, disable drag and drop unless in edit mode #1174

Closed
netniV opened this issue Jan 5, 2018 · 4 comments
Closed

When display a tree, disable drag and drop unless in edit mode #1174

netniV opened this issue Jan 5, 2018 · 4 comments

Comments

@netniV
Copy link
Member

netniV commented Jan 5, 2018

You have the ability to drag and drop from the two columns on the right hand side over to the left side column when you have no ability to actually add items. These two columns should be disabled unless you are editing (ie, when the Edit Tree button has been clicked enable the columns, disable on Finish Editing)

@cigamit
Copy link
Member

cigamit commented Jan 5, 2018

Please upload an animation. Thanks!

@netniV
Copy link
Member Author

netniV commented Jan 5, 2018

The following animation shows what I was referring to. In better terms, drag is allowed by drop is disabled before the Edit Tree button is used. Dragging should really be disabled and the columns potentially a dulled colour to show that editing is not available?

cacti-graph-drag

@cigamit
Copy link
Member

cigamit commented Jan 5, 2018

Needs to be a css class. Easy to do though.

cigamit added a commit that referenced this issue Jan 6, 2018
Disable tree edit drag and drop when tree is not in edit mode
@cigamit
Copy link
Member

cigamit commented Jan 6, 2018

Resolved. Used javascript.

@cigamit cigamit closed this as completed Jan 16, 2018
@netniV netniV changed the title Drag and drop available on /tree.php?action=edit before edit is clicked When display a tree, disable drag and drop unless in edit mode Dec 31, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants