Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate Graph is being shown more than once, leading to layout/display issues #2644

Closed
DavidLiedke opened this issue Apr 25, 2019 · 16 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@DavidLiedke
Copy link
Contributor

Describe the bug
Unable to see Aggregate Graph in Device View

To Reproduce
Steps to reproduce the behavior:

  1. Go to Graphs
  2. Click on selected device
  3. Scroll down to the aggregate graph

Expected behavior
If you click on "Graph Details" or "Time Graph View" you can see the graph.

Screenshots
1.
firefox_2019-04-25_07-42-03
2.
firefox_2019-04-25_07-42-16

@cigamit
Copy link
Member

cigamit commented Apr 26, 2019

@DavidLiedke, is this a Windows box? If not, provide the debug output (rrdtool graph ...). If it is, Windows has problems with long strings, or used to years ago. Not sure if it still persists.

@DavidLiedke
Copy link
Contributor Author

No it is a linux system (openSUSE 15.0).

I need to correct my error message. The graph is displayed after all. But cacti wants to display it next to the graph again. This only happens in the Device View.

Overview:

firefox_2019-04-26_07-38-46

Graph 1:

2019-04-26_07-39-24

firefox_2019-04-26_07-47-30
graph.php?action=zoom&local_graph_id=840&rra_id=0&graph_start=1556171100&graph_end=1556257500

firefox_2019-04-26_07-47-37
graph.php?local_graph_id=840

firefox_2019-04-26_07-47-43
graph_view.php?page=1&graph_template_id=-1&host_id=-1&filter=&style=selective&action=preview&graph_add=14%2C203%2C815%2C816%2C

Graph 2:

2019-04-26_07-39-39

firefox_2019-04-26_07-47-30
graph.php?action=zoom&local_graph_id=840&rra_id=0&graph_start=1556171100&graph_end=1556257500

firefox_2019-04-26_07-47-37
graph.php?local_graph_id=840

firefox_2019-04-26_07-47-43
graph_view.php?page=1&graph_template_id=-1&host_id=-1&filter=&style=selective&action=preview&graph_add=14%2C203%2C815%2C816%2C

@kurowskydb
Copy link

What browser are you using? Also try private / incognito tab to see if extensions are affecting. Had similar issue of a particular type of graph not showing in chrome. Disabled some extensions, restarted and the graph appeared... :/

@cigamit
Copy link
Member

cigamit commented Apr 28, 2019

Need to see the browser console, and the debug output.

@DavidLiedke
Copy link
Contributor Author

Issue exist in all browsers (Microsoft Edge, Google Chrome and Firefox).
Microsoft Edge has no extensions. In Firefox & Google Chrome the extensions are disabled for this URL.

chrome_2019-04-29_07-51-46

chrome_2019-04-29_07-53-00

In the debug log i cant find anything. Also there is no entry in the apache error log.

@netniV
Copy link
Member

netniV commented Apr 29, 2019

So the setTimeout warning is that it is above the 50ms which is chromes default warning limit for execution time of animation based events. See https://stackoverflow.com/questions/41218507/violation-long-running-javascript-task-took-xx-ms and https://stackoverflow.com/questions/42218699/javascript-chrome-violation-violation-handler-took-83ms-of-runtime/44824402#44824402

So, it's unlikely that they are what is causing your issue. Since everything appears to be OK with the status result etc, I can only assume that the data coming back isn't a valid image (or has a PHP notification/warning smack in the middle of it corrupting the data).

When you browse those URLs directly, what do you get? Can you use wget to download the data and post it as a data (rather than image file)?

@DavidLiedke
Copy link
Contributor Author

DavidLiedke commented Apr 29, 2019

If i browse this URLs ( graph_json.php?rra_id=0&local_graph_id=840&graph_start=1556440072&graph_end=1556526472&graph_height=120&graph_width=500 ) directly i get the JSON RAW Data.

56785735-c4083a00-67f6-11e9-90f6-1f5ad5a95598

The aggregate graph works without any problems. But Cacti wants to show this graph two times. The first time (left) is shown. The second time it is not displayed. I can click the buttons (Graph Details, CSV Export, Time Graph View, Display Graphs from this Aggregate) of both graphs without any problems.

[Image Removed]

@netniV
Copy link
Member

netniV commented Apr 29, 2019

Oh, so my bad. This is a case of trying to display it more than once... But, if I now understand the issue right, that will likely cause issues because the div's ID that is used to inject the image already exists so it won't be updating both I imagine.

Somewhere, there needs to be a dedupe of the graphs being used, to ensure we don't have multiple entries.

@netniV
Copy link
Member

netniV commented Apr 29, 2019

Looking back up, that is the real issue as these are both for graph id 840.

@netniV netniV changed the title [Cacti 1.2.3] Unable to see Aggregate Graph in Device View Aggregate Graph is being shown more than once, leading to layout/display issues Apr 29, 2019
@DavidLiedke
Copy link
Contributor Author

I had only one aggregate graph in my system. And this problem only happends in the "device view".

@cigamit
Copy link
Member

cigamit commented Apr 29, 2019

I think @netniV got it right. Likely an ID issue. We will move this fix to 1.2.5. Patch real soon though.

@cigamit cigamit added the bug Undesired behaviour label Apr 29, 2019
@cigamit cigamit added this to the v1.2.5 milestone Apr 29, 2019
@pautiina
Copy link
Contributor

pautiina commented Apr 30, 2019

I also have this bug. It's happening on 1.2.2 release

cigamit added a commit that referenced this issue May 5, 2019
Aggregate Graph is being shown more than once, leading to layout/display issues
@cigamit cigamit added the resolved A fixed issue label May 5, 2019
@cigamit
Copy link
Member

cigamit commented May 5, 2019

This is resolved now. Moved to 1.2.4 milestone due to the delays.

@cigamit cigamit modified the milestones: v1.2.5, v1.2.4 May 5, 2019
@onnieBLT
Copy link

onnieBLT commented May 6, 2019

When will the new version be released?

@DavidLiedke
Copy link
Contributor Author

Thx. Problem is fixed.

@netniV
Copy link
Member

netniV commented May 6, 2019

We are just trying to test/tweak the installer and once we are confident in that, it will be released. I was going to be this weekend, but I think it'll be Saturday now just to give us a bit more time.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

6 participants