Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Device Template categories to match the classes of the Package Plugin #4957

Closed
TheWitness opened this issue Oct 16, 2022 · 12 comments
Closed
Labels
device template Feature associated with a Device Template enhancement General tag for an enhancement feedback needed A Feature Request that The Cacti Group is soliciting feedback on. resolved A fixed issue
Milestone

Comments

@TheWitness
Copy link
Member

Feature Request

Is your feature request related to a problem? Please describe

Add Classes to Device Templates to match those defined in the unreleased Package Plugin.

Describe the solution you'd like

These have been needed for several years, but not implemented.

Describe alternatives you've considered

Prefixing Templates with names. Not nice.

@TheWitness TheWitness added the enhancement General tag for an enhancement label Oct 16, 2022
TheWitness added a commit that referenced this issue Oct 16, 2022
Add Device Template Classes to match the Classes in Upcoming release of the Package Plugin
@TheWitness TheWitness added the resolved A fixed issue label Oct 16, 2022
@TheWitness
Copy link
Member Author

Have proposed the following device classes. Awaiting feedback before finalizing/closing.

$device_classes = array(
	'application'  => __('Application Related'),
	'cacti'        => __('Cacti Related'),
	'database'     => __('Database Related'),
	'facilities'   => __('Facilities Related'),
	'general'      => __('Generic Device'),
	'hpc'          => __('HPC/Grid Computing'),
	'hypervisor'   => __('Hypervisor Related'),
	'license'      => __('Licensing Related'),
	'linux'        => __('Linux Related'),
	'loadbalancer' => __('Load Balancer'),
	'switch'       => __('Network Switch'),
	'router'       => __('Network Router'),
	'firewall'     => __('Network Firewall'),
	'storage'      => __('Storage Related'),
	'telephony'    => __('Telco Related'),
	'webserver'    => __('Web Server Related'),
	'windows'      => __('Windows Related'),
	'ups'          => __('UPS Related'),
	''             => __('Unassigned')
);

@bmfmancini
Copy link
Member

Media converter ( Fiber optic related or telco related )

@TheWitness
Copy link
Member Author

What do you prefer, removing Telco Related and adding a number of others? You are the expert...

@bmfmancini
Copy link
Member

bmfmancini commented Oct 16, 2022

Yeah remove the telco in my opinion alot of these devices can be put under that category

@TheWitness
Copy link
Member Author

Okay, provided an updated list. That would be great. No rush.

@TheWitness
Copy link
Member Author

Completing the circular reference here:

#3421

@TheWitness TheWitness added the device template Feature associated with a Device Template label Oct 17, 2022
@xmacan
Copy link
Member

xmacan commented Oct 17, 2022

Wifi (ap, controller)

@xmacan
Copy link
Member

xmacan commented Oct 17, 2022

Something like management (ILO, IPMI, iDrac, ...)

@TheWitness
Copy link
Member Author

TheWitness commented Oct 17, 2022

Like this?

$device_classes = array(
    'remotemgmt' => __('ILO, IPMI, iDrac, etc.')
);

@TheWitness TheWitness added the feedback needed A Feature Request that The Cacti Group is soliciting feedback on. label Oct 17, 2022
@xmacan
Copy link
Member

xmacan commented Oct 17, 2022

Please add wireless

@TheWitness
Copy link
Member Author

@xmacan, Wireless as in what? Review the Example I provided @bmfmancini .

device_classes = array(
    'wireless' => __('Daffy Duck, Fred Flintstone, etc.')
);

??

TheWitness added a commit that referenced this issue Nov 17, 2022
@TheWitness
Copy link
Member Author

Okay, added both.

@TheWitness TheWitness added this to the v1.2.23 milestone Nov 17, 2022
@netniV netniV changed the title Add Device Template Classes to match the Classes in Upcoming release of the Package Plugin Add Device Template categories to match the classes of the Package Plugin Dec 31, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
device template Feature associated with a Device Template enhancement General tag for an enhancement feedback needed A Feature Request that The Cacti Group is soliciting feedback on. resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

3 participants