Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message not showing when confirming password #16

Closed
wants to merge 1 commit into from

Conversation

micke2k
Copy link
Contributor

@micke2k micke2k commented Mar 11, 2016

Function secpass_check_pass returned "ok" when confirmation of password was happening. This printed "ok" instead of "Your new passwords do not match"

Also added password policy to the html and removed shadows in text for modern skin.

passwordchanges

Function secpass_check_pass returned "ok" when confirmation of password was happening. This printed "ok" instead of "Your new passwords do not match"

Also added password policy to the html and removed shadows in text for modern skin.
@cigamit
Copy link
Member

cigamit commented Mar 19, 2016

This one needs a little more work mike2k. If you look into the various forms in the development branch, you will see there is a question mark and tooltip presented on the various pages. There is a new function display_tooltip(html) that you can call to add a tooltip to a page.

If you can rework this pull request to place your html in the tooltip function and place the tooltip to the right of the first new password textbox form item, it'll be acceptable. In addition, you need to pull the settings for the C2 rules from the database using read_config_option() instead of the static values that you have used.

If you can redo this pull that way instead, we can merge it.

@micke2k
Copy link
Contributor Author

micke2k commented Mar 19, 2016

Alright, thanks for the input! Ill get to work with it

@micke2k micke2k closed this Mar 19, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants