-
-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: php argument composition #2653
Conversation
…emble_php_args()' in /lib/functions.php.
…gs in assemble_php_args().
To give some insight as to how this looks like in
Can we assume, that |
So I merged this, rolled it back and applied a patch containing all the changes to the 13 branch (including the earlier #2643 changes and some other minor ones that @cigamit had done). However, on my Ubuntu system, the poller suddenly started to generate a time exceed warning and as I didn't have the time to debug it I just disabled my test poller to prevent being spammed by mails. Once I have the 1.2.4 release completed, I shall be revisiting it to see why but there's already an issue outstanding which makes me feel it was definitely the right choice to roll it back out for now. |
Moves the composition of arguments to a backgrounded php call (i.e. when using
shell_exec
orexec
) toassemble_php_args()
inlib/functions.php
. Further establishes details discussed in #2643.This works for me during installation. However, when using an unset global php configuration (while serving cacti with all requirements via uwsgi) and spawning external php processes, these throw warnings as they can't load certain (probably builtin) extensions, which are not found in the default extensions path. I don't know what to do about that.
Therefore, please review and test! Also, please advise in regards to function documentation.
Also: I had to apply the directory for
$path_cactilog
twice during installation, before it got picked up and the next installation step gets started. However, this was also the case before applying this patch.