First attempt at new install #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added check for RRD 1.5 2. Backported dependencies check 3. Backported template installer 4. Added theme selection Tested and working with new installation on Linux. Backported a template for testing as well -> Disk IO. I will test the Upgrade and Windows installation as well as clean it up and add some extras.
…s/installupdate
Tables were not created because primary key was: KEY PRIMARY 'id' Instead of PRIMARY KEY 'id Saw some weird behaviour when switching between 0.8.8g and 1.0, this was solved when browser was closed between upgrades. Removed top and bottom header Issues: 1. the new way of creating tables with db_create_table doesnt give any log output, if it fails it fails silently. 2. after upgrade user are sent to login page but cant login with admin/admin, realm problem?
This fixed the login issue. Now upgraded database and new installed database is exactly equal, no difference. Still need to fix/test: 1. output for array sql log 2. test windows 3. cleanup, import more features, make it look better Works: Linux New install Upgrade from 0.8.8g
| @@ -365,8 +364,8 @@ function upgrade_to_1_0_0() { | |||
| // Add secpass fields | |||
| db_install_add_column ('1.0', 'user_auth', array('name' => 'lastchange', 'type' => 'int(12)', 'NULL' => false, 'default' => '-1')); | |||
| db_install_add_column ('1.0', 'user_auth', array('name' => 'lastlogin', 'type' => 'int(12)', 'NULL' => false, 'default' => '-1')); | |||
| db_install_add_column ('1.0', 'user_auth', array('name' => 'password_history', 'type' => 'varchar(4096)', 'NULL' => false, 'default' => '')); | |||
| db_install_add_column ('1.0', 'user_auth', array('name' => 'locked', 'type' => 'varchar(3)', 'NULL' => false, 'default' => '')); | |||
| db_install_add_column ('1.0', 'user_auth', array('name' => 'password_history', 'type' => 'INT(12)', 'NULL' => false, 'default' => '-1')); | |||
There was a problem hiding this comment.
mistake here. should remain varchar(4096). avoid use of 'text' fields at all cost.
|
I've made some comments. If you can update, that would be good. |
|
Ill fix it. The values comes from cacti.sql, ill fix that one too. Thanks for the comments! Edit: i might have made som mistakes, anyway ill look into it. |
Change cacti.sql datetime to timestamp, good idea?
|
before merging, let's do those other two changes. |
|
yup agreed ill fix them Edit: Saw you comment on the closed pull now, im on it |
…s/installupdate
Added back index parent. Although i don't think it should be used since it is not in cacti.sql, see attached screenshot. cacti2 is the upgraded, and cacti is new installation.
|
|
|
yea, the index should also be on the cacti.sql file. I'll merge this. add the parent index to the cacti.sql in a separate pull. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested and working with a new installation on Linux. Backported a template for testing as well -> Disk IO.
I will test Upgrade and Windows installation, as well as clean it up and add some extras.