Allow pinging to IPv6-only hosts #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a "quick and dirty" patch to allow measuring the latency to hosts which do not have an IPv4 address, but an IPv6 one only. If an IPv4 ping fails with an "unknown host" then, with this patch, cacti will simply retry with the ping6 command. Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
|
in lib/ping.php, I'd prefer to use a function call to determine if the ip address is v6 or not and use the correct shell exec right from the start. I think you will find a check for ipv6 ip's in the code. We also have to accommodate people who want to append port numbers to the ip's when SNMP is not running on a known port, for example 192.168.1.100:165. Make sense. The same should apply to the perl script too don't you think? |
|
i am going to close this due to some merge conflicts. however, please review what was committed. it should suffice, and is quite close to what you had. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a "quick and dirty" patch to allow measuring the latency
to hosts which do not have an IPv4 address, but an IPv6 one only.
If an IPv4 ping fails with an "unknown host" then, with this patch,
cacti will simply retry with the ping6 command.
Signed-off-by: Linus Lüssing linus.luessing@c0d3.blue