Attempt at fixing graph template duplication. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Graphs duplication throws error: [Wed Apr 13 19:43:47.904730 2016] [:error] [pid 5875] [client 192.168.206.1:25885] PHP Notice: Undefined index: t_general_header in /var/www/html/commitcommit4868/lib/utility.php on line 564, referer: http://192.168.206.136/cacti/graph_templates.php [Wed Apr 13 19:43:47.904805 2016] [:error] [pid 5875] [client 192.168.206.1:25885] PHP Notice: Undefined index: scaling_header in /var/www/html/commitcommit4868/lib/utility.php on line 563, referer: http://192.168.206.136/cacti/graph_templates.php [Wed Apr 13 19:43:47.904813 2016] [:error] [pid 5875] [client 192.168.206.1:25885] PHP Notice: Undefined index: t_scaling_header in /var/www/html/commitcommit4868/lib/utility.php on line 564, referer: http://192.168.206.136/cacti/graph_templates.php [Wed Apr 13 19:43:47.904844 2016] [:error] [pid 5875] [client 192.168.206.1:25885] PHP Notice: Undefined index: grid_header in /var/www/html/commitcommit4868/lib/utility.php on line 563, referer: http://192.168.206.136/cacti/graph_templates.php [Wed Apr 13 19:43:47.904850 2016] [:error] [pid 5875] [client 192.168.206.1:25885] PHP Notice: Undefined index: t_grid_header in /var/www/html/commitcommit4868/lib/utility.php on line 564, referer: http://192.168.206.136/cacti/graph_templates.php [Wed Apr 13 19:43:47.904863 2016] [:error] [pid 5875] [client 192.168.206.1:25885] PHP Notice: Undefined index: axis_header in /var/www/html/commitcommit4868/lib/utility.php on line 563, referer: http://192.168.206.136/cacti/graph_templates.php [Wed Apr 13 19:43:47.904868 2016] [:error] [pid 5875] [client 192.168.206.1:25885] PHP Notice: Undefined index: t_axis_header in /var/www/html/commitcommit4868/lib/utility.php on line 564, referer: http://192.168.206.136/cacti/graph_templates.php [Wed Apr 13 19:43:47.904881 2016] [:error] [pid 5875] [client 192.168.206.1:25885] PHP Notice: Undefined index: legend_header in /var/www/html/commitcommit4868/lib/utility.php on line 563, referer: http://192.168.206.136/cacti/graph_templates.php [Wed Apr 13 19:43:47.904886 2016] [:error] [pid 5875] [client 192.168.206.1:25885] PHP Notice: Undefined index: t_legend_header in /var/www/html/commitcommit4868/lib/utility.php on line 564, referer: http://192.168.206.136/cacti/graph_templates.php [Wed Apr 13 19:49:26.249934 2016] [:error] [pid 55534] [client 192.168.206.1:25932] PHP Notice: Undefined index: t_general_header in /var/www/html/commitcommit4868/lib/utility.php on line 564, referer: http://192.168.206.136/cacti/graph_templates.php Fixing by unsetting all headers before we duplicate. We probably shouldn't be reading them in, in the first place?
|
That's not the right way to solve this one. Will have to test it locally. Might be the fact that the default values are NULL in the database upgrade script. Check that if you have a moment. |
|
micke, undo what you did and add the following to line 563 if ($array['method'] == 'spacer') continue; see if that helps... |
|
my proposed fix was inadvertently committed in 6591554 |
|
yes, that makes a lot more sense, ill test it. Thanks! |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Graphs duplication throws error:
PHP Notice: Undefined index: t_general_header in /lib/utility.php on line 564, referer: http://192.168.206.136/cacti/graph_templates.php
PHP Notice: Undefined index: scaling_header in /lib/utility.php on line 563, referer: http://192.168.206.136/cacti/graph_templates.php
PHP Notice: Undefined index: t_scaling_header in /lib/utility.php on line 564, referer: http://192.168.206.136/cacti/graph_templates.php
PHP Notice: Undefined index: grid_header in /lib/utility.php on line 563, referer: http://192.168.206.136/cacti/graph_templates.php
PHP Notice: Undefined index: t_grid_header in/lib/utility.php on line 564, referer: http://192.168.206.136/cacti/graph_templates.php
PHP Notice: Undefined index: axis_header in /lib/utility.php on line 563, referer: http://192.168.206.136/cacti/graph_templates.php
PHP Notice: Undefined index: t_axis_header in /lib/utility.php on line 564, referer: http://192.168.206.136/cacti/graph_templates.php
PHP Notice: Undefined index: legend_header in /lib/utility.php on line 563, referer: http://192.168.206.136/cacti/graph_templates.php
PHP Notice: Undefined index: t_legend_header in /lib/utility.php on line 564, referer: http://192.168.206.136/cacti/graph_templates.php
PHP Notice: Undefined index: t_general_header in/lib/utility.php on line 564, referer: http://192.168.206.136/cacti/graph_templates.php
Fixing by unsetting all headers before we duplicate. We probably shouldn't be reading them in, in the first place?