Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mss970 patch 1 (issue#5776: Undefined array key "description" in file settings.php) #5778

Closed
wants to merge 6 commits into from

Conversation

MSS970
Copy link

@MSS970 MSS970 commented Jun 25, 2024

issue#5776: Undefined array key "description" in file settings.php

ERROR PHP WARNING: Undefined array key "description" in file: D:\cacti\apache\htdocs\cacti\settings.php on line: 1221 #5776

The following setting (Tab, Field Name, Field Array) DOES NOT HAVE a 'description' key:

Tab: "alerts" field_name: "thold_notification_delay" method: "hidden"
key: friendly_name
value: Device Notification Delay Options
key: method
value: hidden

issue#5776: Undefined array key "description" in file settings.php
ERROR PHP WARNING: Undefined array key "description" in file: D:\cacti\apache\htdocs\cacti\settings.php on line: 1221 Cacti#5776
Line 1221:

elseif (($field_array['method'] != 'hidden')) {
Update html_form.php Undefined array key "default", Issue#Cacti#5780
Update CHANGELOG issue#5780
@MSS970
Copy link
Author

MSS970 commented Jun 27, 2024

Dear Team,
Kindly can you review this change to resolve 2 issues #5780 and #5776

@TheWitness
Copy link
Member

Looks good. I'm going to implement just a little differently though as it also impacts 1.2.x. Thanks for the contribution.

@TheWitness
Copy link
Member

This is resolved now by the following two commits.

8a58c8f
and
f364ec3

@TheWitness TheWitness closed this Jun 29, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants