Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass constant to set_locale() #60

Merged
merged 1 commit into from
Aug 18, 2016
Merged

Pass constant to set_locale() #60

merged 1 commit into from
Aug 18, 2016

Conversation

neclimdul
Copy link
Contributor

No description provided.

@neclimdul
Copy link
Contributor Author

This fixes a warning I'm getting when running poller in php 7.

PHP Warning:  setlocale() expects parameter 1 to be integer, string given in /var/www/html/cacti/include/global_languages.php on line 574
PHP Warning:  setlocale() expects parameter 1 to be integer, string given in /var/www/html/cacti/include/global_languages.php on line 574
PHP Warning:  setlocale() expects parameter 1 to be integer, string given in /var/www/html/cacti/include/global_languages.php on line 574
PHP Warning:  setlocale() expects parameter 1 to be integer, string given in /var/www/html/cacti/include/global_languages.php on line 574
PHP Warning:  setlocale() expects parameter 1 to be integer, string given in /var/www/html/cacti/include/global_languages.php on line 574

This would have never worked though because even in PHP 5 it required at least an integer but we're passing a string.

@cigamit cigamit merged commit 445c350 into Cacti:develop Aug 18, 2016
@chrisc980 chrisc980 mentioned this pull request Mar 22, 2019
Closed
@arbenatti arbenatti mentioned this pull request Apr 5, 2019
Closed
@arno-st arno-st mentioned this pull request Sep 19, 2019
Closed
@gundalba gundalba mentioned this pull request Jan 28, 2020
Closed
@patoberli patoberli mentioned this pull request Feb 10, 2020
Closed
@jmcdomingues jmcdomingues mentioned this pull request Mar 9, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neclimdul @cigamit