Fixed while loop when graph is not created. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating new graphs graph_json throws an error and spikes CPU. [Sat Jan 30 00:06:27.947764 2016] [:error] [pid 44971] [client :64833] PHP Fatal error: Maximum execution time of 30 seconds exceeded in /var/www/html/cacti/graph_json.php on line 143, referer: http:///cacti/graph_view.php This is until the graph has been created and can be found. Changed it to check for a RRD and if not found set a placeholder image. Code doesn't loop anymore.
|
I can confirm this issue and this PR fixes it. |
browniebraun
added a commit
that referenced
this pull request
Feb 5, 2016
Fixed while loop when graph is not created.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating new graphs graph_json throws an error and spikes CPU.
[Sat Jan 30 00:06:27.947764 2016] [:error] [pid 44971] [client :64833] PHP Fatal error: Maximum execution time of 30 seconds exceeded in /var/www/html/cacti/graph_json.php on line 143, referer: http:///cacti/graph_view.php
This is until the graph has been created and can be found.
Changed it to check for a RRD and if not found set a placeholder image. Code doesn't loop anymore.