Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature custom social #124

Merged
merged 8 commits into from
Dec 27, 2016
Merged

Feature custom social #124

merged 8 commits into from
Dec 27, 2016

Conversation

Innectic
Copy link
Member

@Innectic Innectic commented Dec 26, 2016

Fixes #91

response.append(', ')
else:
return "'{}' not found on the streamer's profile!".format(
', '.join(services))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't .join(services) be .join(service)? Some of the services might not exist, just not this current one

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

return MessagePacket(*response[:-1])
else:
return "'{}' not found on the streamer's profile!".format(
', '.join(services))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@Innectic Innectic merged commit c2b555b into develop Dec 27, 2016
@Innectic Innectic deleted the feature/custom-social branch December 27, 2016 00:02
@Innectic Innectic mentioned this pull request Dec 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants