Build wheels for 7.7.0 #7

fpq473 · 2023-01-08T17:48:59Z

Match latest versions of ocp and vtk conda packages.

VTK manylinux wheels are now available on PyPI for
3.10, so remove use of third-party wheel.

jmwright · 2023-01-10T13:22:49Z

@fpq473 Is this going to run into the same glibc versioning problem that we have with 7.6.*?

fpq473 · 2023-01-10T16:15:55Z

@jmwright The fix in a54b3c7 allowed us to produce manylinux_2_31 wheels for 7.6, matching what we had for 7.5. So the requirement is debian 11 or ubuntu 20.04, which isn't the greatest, but still useful.

This change will (hopefully) build the same for 7.7.

fpq473 · 2023-01-10T16:19:52Z

And just FTR, here are the 7.6.3a0 wheels released last October:

https://pypi.org/project/cadquery-ocp/7.6.3a0/#files

It's an alpha release (matching the conda package), so the PyPI page still says 7.5.3.0.

jmwright · 2023-01-10T16:35:55Z

I've tried building a final 7.6.3.0 release before merging this, but things aren't working again.

https://github.com/CadQuery/ocp-build-system/actions/runs/3884118392/jobs/6626257305#step:8:98879

fpq473 · 2023-01-10T17:27:28Z

I committed some fixes to try to get 7.6.3.0 to build.

But there is still one problem which you might know how to fix: the conda install command is installing 7.6.3.alpha from the cadquery channel instead of 7.6.3.0 from conda-forge.

I already tried 2102e5d but it seemingly had no effect.

fpq473 · 2023-01-10T18:20:17Z

Okay, I managed to get 7.6.3.0 to install. But now there are glibc versioning problems like you noted.

I'll think about it.

jmwright · 2023-01-10T18:58:52Z

@fpq473 Thanks.

I think the proper way to fix this kind of problem and to support other platforms like ARM properly, is to do from-scratch compilation of the toolchain (VTK, OCCT, OCP, etc) so we have more control over the glibc version. It's very involved to build everything from scratch though.

fpq473 · 2023-01-10T19:52:02Z

I did some debugging. The workflow logs say:

2023-01-10T17:55:46.2566145Z DEBUG:auditwheel.policy.versioned_symbols:Package requires GLIBCXX_3.4.29, incompatible with policy manylinux_2_31_x86_64 ...
2023-01-10T17:55:46.2566962Z DEBUG:auditwheel.policy.versioned_symbols:Package requires CXXABI_1.3.13, incompatible with policy manylinux_2_31_x86_64 ...

This requirement is coming from OCP.so file:

./OCP.cpython-310-x86_64-linux-gnu.so:     file format elf64-x86-64
  9264f7:       ff 15 a3 05 d0 07       callq  *0x7d005a3(%rip)        # 8626aa0 <std::__exception_ptr::exception_ptr::_M_addref()@CXXABI_1.3.13>
  926512:       ff 15 90 ff cf 07       callq  *0x7cfff90(%rip)        # 86264a8 <std::__exception_ptr::exception_ptr::_M_release()@CXXABI_1.3.13>
  926527:       ff 15 73 05 d0 07       callq  *0x7d00573(%rip)        # 8626aa0 <std::__exception_ptr::exception_ptr::_M_addref()@CXXABI_1.3.13>
  c7f09e:       ff 15 cc 2e 98 07       callq  *0x7982ecc(%rip)        # 8601f70 <std::__throw_bad_array_new_length()@GLIBCXX_3.4.29>
  c7f42e:       ff 15 3c 2b 98 07       callq  *0x7982b3c(%rip)        # 8601f70 <std::__throw_bad_array_new_length()@GLIBCXX_3.4.29>
  c7f796:       ff 15 d4 27 98 07       callq  *0x79827d4(%rip)        # 8601f70 <std::__throw_bad_array_new_length()@GLIBCXX_3.4.29>

This is specific to the 7.6.3.0 package on conda-forge. The 7.6.3.alpha and 7.7.0.alpha packages on the cadquery channel do not have this problem. So there is some difference in how these packages are compiled (but not sure how/where these builds are done).

Should we (1) try to identify the differences, or (2) just build and release 7.7.0.alpha, or (3) throw in the towel?

fpq473 · 2023-01-10T19:55:56Z

Fourth option: release 7.6.3.0 as a manylinux_2_34 wheel. This requires newer distros, e.g. fedora 35, ubuntu 21.10, debian testing.

jmwright · 2023-01-10T20:44:49Z

It looks like all the OCP builds, even the OCCT 7.7 ones are using Ubuntu 18.04, so the system's glibc version shouldn't be the problem. It must be something with how conda is solving and setting up the environments.

https://dev.azure.com/cadquery/OCP/_build/results?buildId=2552&view=results

Maybe the best thing to do is your option #4 first, followed by a build and release of 7.7 alpha.

What do you think @fpq473 ?

fpq473 · 2023-01-10T22:51:03Z

We can do (4) but after additional reflection, it seems like a potential pain point to support -- when users are unable to install cadquery-ocp, it may be because they didn't say pip install --pre or maybe it's their linux distro version.

I can try to test your theory by comparing build logs, but I can't find the 7.6.3.0 build log. Can you?

The 7.6.3.0 files were uploaded to conda-forge around Dec 30. The Azure pipeline runs you linked to go back to September, but none of them appear to be for 7.6.3.0 -- all the December runs are titled "Start with 7.7.0".

https://dev.azure.com/cadquery/OCP/_build?definitionId=6

jmwright · 2023-01-10T23:59:01Z

The latest commit I see on master for 7.6.3 is Sept. https://github.com/CadQuery/OCP/commits/master

The latest release is the 7.6.3.0 tag on Nov 23rd. I don't see any Azure logs for that tag, but that tag points back to the September commit for 7.6.3, which does have logs.
https://github.com/CadQuery/OCP/releases

fpq473 · 2023-01-11T17:02:22Z

@jmwright Are you still referring to the Azure builds? None of them are for 7.6.3.0, as far as I can tell. The log output indicates that 7.7.0.alpha or 7.6.3.alpha are being built.

Also I see that this line {% set OCP_TWEAK = "alpha" %} has existed in OCP for over a year, so if it means what I think it means, it seems unlikely that a non-alpha build was done via github/azure.

https://github.com/CadQuery/OCP/blame/2cb2dba8674c58d6ede38fd27619a09e850856e8/conda/meta.yaml#L2

Is it possible the upload was done as a one-off elsewhere?

jmwright · 2023-01-17T21:18:11Z

@fpq473 Unless you object, I'm going to do the following.

Do a "fake" 7.6.3.0 release.
Start work on reviewing/merging this branch

fpq473 · 2023-01-17T22:46:34Z

@jmwright Sounds like a plan!

jmwright · 2023-01-18T21:28:12Z

@fpq473 Sorry that I made such a mess of this. 7.6.3 has been published and we can move ahead with this PR. I ended up using 7.6.3 as the version number rather than 7.6.3.0 because we didn't have the trailing 0 in the last release version number.

fpq473 · 2023-01-18T22:56:10Z

I see 7.6.3 on pypi, awesome, nicely done.

Do you want to release 7.7.0.alpha now, or just a straight up 7.7.0?

jmwright · 2023-01-18T23:05:51Z

Do you want to release 7.7.0.alpha now, or just a straight up 7.7.0?

Let's do an alpha first just to be safe.

- VTK manylinux wheels are now available on PyPI for 3.10, so remove use of third-party wheel. - Move version wrangling into setup.py to prepare for "7.7.0" release

fpq473 · 2023-01-19T01:10:59Z

@jmwright I updated this PR for 7.7.0.alpha. Also tried to centralize the version wrangling. Tested on Linux.

jmwright

Thanks @fpq473 ! Let's see how it works.

jmwright · 2023-01-19T01:31:34Z

@fpq473 Looks like there's a version conflict.

https://github.com/CadQuery/ocp-build-system/actions/runs/3954442641/jobs/6771785613#step:5:56

fpq473 requested a review from jmwright January 8, 2023 17:49

fpq473 force-pushed the ocp77 branch from 34597b8 to bdc9a2e Compare January 8, 2023 18:09

fpq473 changed the title ~~Build wheels for 7.7.0.alpha~~ Build wheels for 7.7.0 Jan 8, 2023

fpq473 mentioned this pull request Jan 11, 2023

Linux build platform for manylinux compat conda-forge/ocp-feedstock#19

Closed

Build "7.7.0a0" wheels from 7.7.0.alpha in cadquery channel

d7019a9

- VTK manylinux wheels are now available on PyPI for 3.10, so remove use of third-party wheel. - Move version wrangling into setup.py to prepare for "7.7.0" release

fpq473 force-pushed the ocp77 branch from bdc9a2e to d7019a9 Compare January 19, 2023 01:05

jmwright approved these changes Jan 19, 2023

View reviewed changes

jmwright merged commit 36c617f into CadQuery:main Jan 19, 2023

fpq473 mentioned this pull request Jan 19, 2023

Fixing 7.7.0 manylinux build #10

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build wheels for 7.7.0 #7

Build wheels for 7.7.0 #7

fpq473 commented Jan 8, 2023 •

edited

Loading

jmwright commented Jan 10, 2023

fpq473 commented Jan 10, 2023

fpq473 commented Jan 10, 2023

jmwright commented Jan 10, 2023

fpq473 commented Jan 10, 2023 •

edited

Loading

fpq473 commented Jan 10, 2023

jmwright commented Jan 10, 2023

fpq473 commented Jan 10, 2023 •

edited

Loading

fpq473 commented Jan 10, 2023

jmwright commented Jan 10, 2023

fpq473 commented Jan 10, 2023

jmwright commented Jan 10, 2023

fpq473 commented Jan 11, 2023

jmwright commented Jan 17, 2023

fpq473 commented Jan 17, 2023

jmwright commented Jan 18, 2023

fpq473 commented Jan 18, 2023

jmwright commented Jan 18, 2023

fpq473 commented Jan 19, 2023

jmwright left a comment

jmwright commented Jan 19, 2023

Build wheels for 7.7.0 #7

Build wheels for 7.7.0 #7

Conversation

fpq473 commented Jan 8, 2023 • edited Loading

jmwright commented Jan 10, 2023

fpq473 commented Jan 10, 2023

fpq473 commented Jan 10, 2023

jmwright commented Jan 10, 2023

fpq473 commented Jan 10, 2023 • edited Loading

fpq473 commented Jan 10, 2023

jmwright commented Jan 10, 2023

fpq473 commented Jan 10, 2023 • edited Loading

fpq473 commented Jan 10, 2023

jmwright commented Jan 10, 2023

fpq473 commented Jan 10, 2023

jmwright commented Jan 10, 2023

fpq473 commented Jan 11, 2023

jmwright commented Jan 17, 2023

fpq473 commented Jan 17, 2023

jmwright commented Jan 18, 2023

fpq473 commented Jan 18, 2023

jmwright commented Jan 18, 2023

fpq473 commented Jan 19, 2023

jmwright left a comment

Choose a reason for hiding this comment

jmwright commented Jan 19, 2023

fpq473 commented Jan 8, 2023 •

edited

Loading

fpq473 commented Jan 10, 2023 •

edited

Loading

fpq473 commented Jan 10, 2023 •

edited

Loading