This repository has been archived by the owner on Apr 13, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed pagination from array to object with perPage & currentPage props
Removed Content-Range and prepared X-Total-Count and Link headers
Added X-Total-Count and Link
Removed Content-Range assertions and update pagination parameters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look's great 👍
'link', | ||
[ | ||
'</api/job-postings?currentPage=1&perPage=2>; rel="first"', | ||
// '</api/job-postings?currentPage=1&perPage=2>; rel="prev"', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's not being used, it's probably best to erase it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alors en fait je peux effectivement tester chaque élément mais seulement de cette manière :
.expect(
'header',
'link',
'</api/job-postings?currentPage=1&perPage=10>; rel="first"'
)
.expect(
'header',
'link',
'</api/job-postings?currentPage=1&perPage=10>; rel="prev"'
)
.expect(
'header',
'link',
'</api/job-postings?currentPage=1&perPage=10>; rel="self"'
)
.expect(
'header',
'link',
'</api/job-postings?currentPage=1&perPage=10>; rel="next"'
)
.expect(
'header',
'link',
'</api/job-postings?currentPage=1&perPage=10>; rel="last"'
)
alexisjanvier
approved these changes
Apr 13, 2020
This was referenced May 2, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cette PR concerne la refonte de la pagination.
Elle implique les changements suivants :
pagination
perPage
¤tPage
Content-Range
X-Total-Count
&Link
Les tests concernant l'en-tête
Link
sont en partie commentés à cause d'une erreur d'interprétation de la value d'en-tête faite par Frisby. J'ai signalé l'erreur ici : vlucas/frisby#557. À voir comment l'erreur est traitée pour ajuster les tests.Related Issue
close #55
ToDo
X-Total-Count
Link
dataProvider
React Admin