Skip to content
This repository has been archived by the owner on Oct 6, 2019. It is now read-only.

Vault PKI Integration #143

Closed
Caiyeon opened this issue Aug 20, 2017 · 4 comments
Closed

Vault PKI Integration #143

Caiyeon opened this issue Aug 20, 2017 · 4 comments
Assignees
Milestone

Comments

@Caiyeon
Copy link
Owner

Caiyeon commented Aug 20, 2017

It would be nice if Goldfish could integrate with Vault's PKI backend. Given a PKI role name, Goldfish should be able to request vault to issue a certificate, and load it into memory in order to serve HTTPS requests. This would require Goldfish to be able to hot-reload its certificate, since it is very possible for vault certificates to be short-lived. Downtime should be ideally zero.

@Caiyeon Caiyeon added this to the 0.7.1 milestone Aug 20, 2017
@Caiyeon Caiyeon self-assigned this Aug 20, 2017
@Caiyeon Caiyeon modified the milestones: 0.7.1, 0.7.2 Sep 18, 2017
@sirlatrom
Copy link

You can see a simple way to choose server certificate per request here: https://github.com/sirlatrom/tls-sidecar-playground/blob/c669423246c12e1666ac2a5341307df85f1a3e9f/dumbserver/main.go#L84

Please copy in the tlsrotater file instead of depending on my version, as it's certainly not guaranteed to stay the same over time.

@sirlatrom
Copy link

PS: I see that with echo, you would have to use the StartServer function and provide the http.TLSConfig on the server instance like I've done in my simple example.

@Caiyeon
Copy link
Owner Author

Caiyeon commented Sep 26, 2017

There's also a chicken and egg problem. Goldfish allows for bootstrapping after launch, but launching requires the certificate. I suppose goldfish can refuse to launch on PKI without a token.

@Caiyeon Caiyeon modified the milestones: 0.7.2, 0.7.1, 0.7.4 Sep 28, 2017
@Caiyeon Caiyeon modified the milestones: 0.7.4, 0.8.0 Oct 25, 2017
Caiyeon added a commit that referenced this issue Nov 16, 2017
Server setup logic moved to modular package, and main function
re-designed to control the server
Caiyeon added a commit that referenced this issue Nov 16, 2017
Caiyeon added a commit that referenced this issue Nov 16, 2017
Caiyeon added a commit that referenced this issue Dec 3, 2017
@Caiyeon
Copy link
Owner Author

Caiyeon commented Dec 4, 2017

Feature has been implemented and tested

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants