Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow translating list values. #27

Merged
merged 3 commits into from
Nov 15, 2016
Merged

Allow translating list values. #27

merged 3 commits into from
Nov 15, 2016

Conversation

ADmad
Copy link
Contributor

@ADmad ADmad commented Nov 11, 2016

Refs #19

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 87.654% when pulling 2aea8c5 on ADmad:translation into ac4bf4a on CakeDC:master.

@CakeDCTeam
Copy link

Hi @ADmad, the build is failing, so could you add some unit tests to increase de coverage and improve it, and fix the code standard, it is breaking the build too. Thanks.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 88.889% when pulling 553044a on ADmad:translation into ac4bf4a on CakeDC:master.

@ADmad
Copy link
Contributor Author

ADmad commented Nov 14, 2016

@CakeDCTeam There you go, the machines are happy now :)

@steinkel
Copy link
Member

thank you @ADmad

@steinkel steinkel merged commit 8eb21c6 into CakeDC:master Nov 15, 2016
@ADmad ADmad deleted the translation branch November 20, 2016 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ADmad @coveralls @CakeDCTeam @steinkel