Fix type error in TinyMCEHelper::beforeRender() #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for: [TypeError] TinyMCE\View\Helper\TinyMCEHelper::beforeRender(): Argument #1 ($viewFile) must be of type TinyMCE\View\Helper\Event, Cake\Event\Event given, called in /web/GenericConference/vendor/cakephp/cakephp/src/Event/EventManager.php on line 329 in /web/GenericConference/vendor/cakedc/tiny-mce/src/View/Helper/TinyMCEHelper.php on line 125
|
@umer936 thank you for your contribution, please check the results of the test workflows and update the failing test case |
|
I was just editing inline on GitHub.dev so I'm not sure if this actually fixes the tests. beforeRender() should run on it's own though when methods are called, right? so it shouldn't need to be in the testcase? |
Hi @umer936 , beforeRender need to be called to test the feature. I see that this bug breaks the way how the plugin work so i will fix it ASAP, thank you for finding this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for:
[TypeError] TinyMCE\View\Helper\TinyMCEHelper::beforeRender(): Argument #1 ($viewFile) must be of type TinyMCE\View\Helper\Event, Cake\Event\Event given, called in /web/GenericConference/vendor/cakephp/cakephp/src/Event/EventManager.php on line 329 in /web/GenericConference/vendor/cakedc/tiny-mce/src/View/Helper/TinyMCEHelper.php on line 125