Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added redragon K552 #1

Conversation

jath03
Copy link

@jath03 jath03 commented Nov 24, 2020

Description

Added Support for the redragon K552 keyboard.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

@CalcProgrammer1 CalcProgrammer1 merged this pull request into SonixQMK:redragon_k556_upstream_orgb Nov 28, 2020
@IslamAlam
Copy link

IslamAlam commented Nov 29, 2020

Hi All,

Based on your code, I reverse engineered BlitzWolf Kb1 which uses the same MCU.
The keyboard is powering up and LEDs are flashing; However, I get the error "Unknown USB Device (Device Descriptor Request Failed)".

https://github.com/IslamAlam/qmk_firmware/tree/blitzwolf_kb1/keyboards/blitzwolf/kb1

What are your tips to fix this issue?
Have you faced a similar one?

This the reverse engineering of the PCB of the keyboard and matrix connection.
https://github.com/IslamAlam/blitzwolf-bw-kb-1

@IslamAlam
Copy link

I have used the head of this branch for testing the keyboard with redragon k552 firmware, I still have the same issue:
image

For some reasons, the keyboard is not providing the correct PID and VID.
image

@CalcProgrammer1
Copy link
Collaborator

CalcProgrammer1 commented Nov 29, 2020 via email

@IslamAlam
Copy link

This is a known issue, it seems Windows has an issue detecting the keyboard using this firmware but Linux does not. I have been doing all my development in Linux. Something with endpoint 0 and the descriptor request is causing Windows to drop the device but I'm not sure what.

On Sun, Nov 29, 2020, 6:06 AM Islam Mansour @.***> wrote: I have used the head of this branch for testing the keyboard with redragon k552 firmware, I still have the same issue: [image: image] https://user-images.githubusercontent.com/4381819/100541288-292dd800-3243-11eb-8cbe-7c176a2e45d8.png For some reasons, the keyboard is not providing the correct PID and VID. [image: image] https://user-images.githubusercontent.com/4381819/100541334-9477aa00-3243-11eb-8760-b8b84d5bd692.png — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIAY7GLFXMKAUIOEWDXFNLSSI2K5ANCNFSM4UAIHNIA .

Thanks, I will test the firmware in my Linux machine to see if it is functional or not then let you know.

@CalcProgrammer1
Copy link
Collaborator

@IslamAlam I fixed the issues on Windows last night. Rebase your work on the latest redragon_k556_upstream branch and update submodules (lib/chibios-contrib) to pull in the changes.

jath03 referenced this pull request in jath03/qmk_firmware Jun 21, 2021
1Conan pushed a commit to 1Conan/qmk_firmware that referenced this pull request Jul 15, 2021
flolbr pushed a commit to flolbr/qmk_firmware that referenced this pull request Apr 3, 2022
Fixing complexity

remove lambda

PR review fixes SonixQMK#1

Removing unneccesary string substitution

Handle -a and specified files

Complexity rewrite, use pathlib
dexter93 added a commit that referenced this pull request Jan 26, 2023
* sn32: revamp the shared RGB driver

* split the rgb logic state config for NPN/PNP
on the non-PWM side of the rgb matrix

* update ROW2COL, cleanup high/low logic

* bump the counter after the scan

* remove atomic blocks
these are not needed for SN32

* formatting

* only reset the counter on wraparound

* fix stray bracket

* ROW2COL: offset cols before the RGB scan

* software pwm control

* fix row2col b/g swap

* make it build

* some pwm updates

* simplify the soft pwm

* small cleanup

* software pwm: move the gpio status change in the handler

* more driver updates

* fix out of bounds bug

* fix one side of the indexing

* sw pwm: update the handlers

* software rgb: full color output

* row2col index fixup: attempt #1

* Revert "row2col index fixup: attempt #1"
don't drink and code kids
This reverts commit b61bf61.

* fixup led indexes

* circumvent stupid hardware decisions
thanks evision

* sw pwm: adjust period based on brightness

* minor fixup

* sw row2col: keep led rows as output

* Revert "sw pwm: adjust period based on brightness"
not having a period big enough for the whole matrix pass is not a good idea.
cols/rows end up not getting scanned and stay dark

This reverts commit e2e2a03.

* actually disable the b/g channels

* only check for OOB access in software COL2ROW

this fixes indexing issues and things are now inline

* prettify and lint it
limelier pushed a commit to limelier/qmk_firmware that referenced this pull request Sep 26, 2023
limelier pushed a commit to limelier/qmk_firmware that referenced this pull request Sep 26, 2023
sonixflasher: overhaul the build logic
javierportillo added a commit to javierportillo/qmk_firmware that referenced this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants