Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entry delete and resend #14

Merged
merged 4 commits into from
Aug 22, 2018
Merged

Entry delete and resend #14

merged 4 commits into from
Aug 22, 2018

Conversation

Shelob9
Copy link
Collaborator

@Shelob9 Shelob9 commented Aug 22, 2018

* @param {String} entryId ID of entry to find.
* @return {Promise<any>}
*/
deleteEntry( formId: string, entryId: number ): Promise<any> {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

* @param {String} entryId ID of entry to find.
* @return {Promise<any>}
*/
resendEntry( formId: string, entryId: number ): Promise<any> {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

@codeclimate
Copy link

codeclimate bot commented Aug 22, 2018

Code Climate has analyzed commit 5b20a4e and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

View more on Code Climate.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 38

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.2%) to 88.75%

Totals Coverage Status
Change from base Build 36: 2.2%
Covered Lines: 95
Relevant Lines: 102

💛 - Coveralls

@Shelob9 Shelob9 merged commit 85f4193 into master Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants