Allow event creation #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krichprollsch
force-pushed
the
create-event
branch
from
275831d
to
f6d8ad0
Compare
| $export['responseStatus'] = $this->getStatus(); | ||
| }; | ||
|
|
||
| return $export; |
There was a problem hiding this comment.
imo we should return the "undecided" status instead of not returning any statuses
There was a problem hiding this comment.
I would like a way to return nothing at all for a patch :/
krichprollsch
force-pushed
the
create-event
branch
from
f6d8ad0
to
4e24e8b
Compare
| 'description' => $this->getDescription(), | ||
| 'start' => ['dateTime' => $this->getStart()->format('c')], | ||
| 'end' => ['dateTime' => $this->getEnd()->format('c')], |
There was a problem hiding this comment.
shouldn't you also expose the timezones ?
There was a problem hiding this comment.
Seems ok according with google documentation
end.dateTime datetime The time, as a combined date-time value (formatted according to RFC3339). A time zone offset is required unless a time zone is explicitly specified in timeZone.
https://developers.google.com/google-apps/calendar/v3/reference/events/insert#request-body
|
ty! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.